Summary: | Password and username are sent as latin1 strings instead of utf8 | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kio-extras | Reporter: | Alexis Murzeau <amubtdx> |
Component: | FISH | Assignee: | Jörg Walter <trouble> |
Status: | REPORTED --- | ||
Severity: | normal | CC: | amubtdx, arthur, cfeck |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | Diff of changes to fish.cpp to send utf8 strings to ssh instead of latin1 |
Description
Alexis Murzeau
2014-03-22 02:43:43 UTC
Thanks for the patch, I am not sure if it should use toLocal8bit() instead. Could you please open a review request at https://git.reviewboard.kde.org/ ? Indeed, I was using utf8 as the system encoding, but according to https://tools.ietf.org/html/rfc4252#section-5 and https://tools.ietf.org/html/rfc4252#section-8 username and password are always in utf8. But I don't know if ssh does any encoding conversion based on the system encoding. At least it seems that the passphrase is used as a byte sequence, so it's encoding is the one used when creating the ssh key. So it would be toLocal8Bit() for the passphrase at least. I just saw that ssh is started with LANG=C LC_ALL=C so maybe ssh expect something else than utf8 for the username and password. But the passphrase is in system encoding no matter the environment variables are Maybe checking if the buffer that contains ssh output contains "passphrase" and in that case, use toLocal8Bit() ? Alexis, I cannot answer your question, since I do not understand the internals. As a member of the bug triaging team, I can only suggest you either start a thread at kde-core-devel mailing list, or a review request. In both cases, KDE developers can discuss the issue and patch better than via this bug tracker. Any progress with the review request? Sorry for late response, I started a thread at kde-core-devel: http://lists.kde.org/?l=kde-core-devel&m=139853883825208&w=2 Thread subject: Fish: ssh key pass-phrase prompt use wrong encoding Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! (In reply to Justin Zobel from comment #6) > Thank you for reporting this issue in KDE software. As it has been a while > since this issue was reported, can we please ask you to see if you can > reproduce the issue with a recent software version? > > If you can reproduce the issue, please change the status to "REPORTED" when > replying. Thank you! Hi, I've retested it, but I think the issue is still present as the code still uses toLatin1 for password: https://github.com/KDE/kio-extras/blob/9ade088f494726651729e1740f05d4bbc48e89b6/fish/fish.cpp#L624 In the meantime I've used passwords without special characters to avoid this issue. |