Bug 332316

Summary:	Lens Auto-Correction should remember previously used settings
Product:	[Applications] digikam	Reporter:	DrSlony <bugs>
Component:	Plugin-Editor-LensCorrection	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs, caulier.gilles
Priority:	NOR
Version:	4.10.0
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/ee758af4c0af598a012ec9500d50775c7b88504d	Version Fixed In:	4.11.0
Sentry Crash Report:

Description DrSlony 2014-03-19 10:46:25 UTC

Use Enhance > Lens > Auto-Correction
[ ] Use metadata (it should be OFF)
Set everything up. Click [OK]

Open a new image, or even the same image, Enhance > Lens > Auto-Correction
Your options are gone! Waste another 15 seconds setting everything up.
Repeat this 100 times a day.
I hope you see why this simple fix is quite serious :]

Reproducible: Always

Comment 1 caulier.gilles 2014-09-02 15:12:51 UTC

DrSlony,

This file still valid using last digiKam 4.2.0 ?

Gilles Caulier

Comment 2 DrSlony 2014-09-02 16:27:08 UTC

Yes this is still valid.

digiKam version 4.2.0
CPU cores: 8
Demosaic GPL2 pack support: No
Demosaic GPL3 pack support: No
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: Yes
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibEigen: 3.2.0
LibExiv2: 0.24
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.13.3
LibKExiv2: 2.3.1
LibKGeoMap: 2.0.0
LibKdcraw: 2.4.2
LibLCMS: 2060
LibLensFun: 0.2.8-0
LibPGF: 6.12.27 - external shared library
LibPNG: 1.6.12
LibQt: 4.8.5
LibRaw: 0.16.0-Beta1
LibTIFF: LIBTIFF, Version 4.0.3 Copyright (c) 1988-1996 Sam Leffler Copyright (c) 1991-1996 Silicon Graphics, Inc.
Marble Widget: 0.18.3 (stable release)
Parallelized PGF codec: No
Parallelized demosaicing: Yes
RawSpeed codec support: No
Database backend: QSQLITE
Kipi-Plugins: 4.2.0
LibKface: 3.4.0
LibKipi: 2.1.0
LibOpenCV: 2.4.9

Comment 3 caulier.gilles 2015-05-17 08:13:02 UTC

DrSlony,

It still valid using last digiKam 4.10.0 ?

Gilles Caulier

Comment 4 DrSlony 2015-05-17 09:54:01 UTC

Yeah, it seems that when metadata is turned off Make and Model are remembered, but not Lens.

Comment 5 caulier.gilles 2015-05-17 10:04:58 UTC

Maik,

Another file where will be easy to do i think...

Gilles

Comment 6 Maik Qualmann 2015-05-23 19:41:09 UTC

Git commit ee758af4c0af598a012ec9500d50775c7b88504d by Maik Qualmann.
Committed on 23/05/2015 at 19:35.
Pushed by mqualmann into branch 'master'.

save and restore all lens auto correction settings if metadata not used
FIXED-IN: 4.11.0

M  +2    -1    NEWS
M  +49   -4    libs/dimg/filters/lens/lensfuncameraselector.cpp

http://commits.kde.org/digikam/ee758af4c0af598a012ec9500d50775c7b88504d

Comment 7 caulier.gilles 2015-05-23 20:54:28 UTC

Git commit fbfb74fc777a5be5e64d565de66b13395ab13b9a by Gilles Caulier.
Committed on 23/05/2015 at 20:53.
Pushed by cgilles into branch 'frameworks'.

backport commit #ee758af4c0af598a012ec9500d50775c7b88504d from git/master to frameworks branch

M  +71   -26   libs/dimg/filters/lens/lensfuncameraselector.cpp

http://commits.kde.org/digikam/fbfb74fc777a5be5e64d565de66b13395ab13b9a

Comment 8 Maik Qualmann 2015-06-04 18:15:20 UTC

Git commit 6f853213e6b240d5e0265371a8e549f4e8e66cc1 by Maik Qualmann.
Committed on 04/06/2015 at 18:13.
Pushed by mqualmann into branch 'master'.

lensfun: is aperture, focus, or object distance <= 0 then the last saved values used

M  +4    -4    libs/dimg/filters/lens/lensfuncameraselector.cpp

http://commits.kde.org/digikam/6f853213e6b240d5e0265371a8e549f4e8e66cc1

Comment 9 caulier.gilles 2015-06-05 19:18:06 UTC

Git commit 9ce7eb53b42e262440d432c5a1dba2b61e56b676 by Gilles Caulier.
Committed on 05/06/2015 at 19:05.
Pushed by cgilles into branch 'frameworks'.

backport commit #6f853213e6b240d5e0265371a8e549f4e8e66cc1 from git/master to frameworks branch

M  +5    -5    libs/dimg/filters/lens/lensfuncameraselector.cpp

http://commits.kde.org/digikam/9ce7eb53b42e262440d432c5a1dba2b61e56b676