Bug 332270

Summary: cantor-4.12.3/src/backends/qalculate/qalculateexpression.cpp:224]: (style) Array index 'i' is used before limits check.
Product: [Applications] cantor Reporter: dcb314
Component: qualculate-backendAssignee: Filipe Saraiva <filipe>
Status: RESOLVED INTENTIONAL    
Severity: normal CC: filipe
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description dcb314 2014-03-18 08:33:51 UTC
Source code is

    if (argument[i] == '\\' && i < argument.size()-1)
        ++i;

Maybe better code might be

    if ( i < argument.size()-1 && argument[i] == '\\')
        ++i;



Reproducible: Always
Comment 1 Filipe Saraiva 2016-05-26 20:04:38 UTC
Thanks for your idea.