| Summary: | Add a KML tag writer for NetworkLinkControl | ||
|---|---|---|---|
| Product: | [Applications] marble | Reporter: | Dennis Nienhüser <nienhueser> |
| Component: | general | Assignee: | Marek Hakala <Hakala.Marek> |
| Status: | RESOLVED FIXED | ||
| Severity: | task | Keywords: | junior-jobs |
| Priority: | NOR | ||
| Version: | 1.7 (KDE 4.12) | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/marble/d9299ef70122fc9f6debc4d5715ac2f712cf9c79 | Version Fixed In: | |
| Sentry Crash Report: | |||
Git commit d9299ef70122fc9f6debc4d5715ac2f712cf9c79 by Dennis Nienhüser, on behalf of Marek Hakala. Committed on 09/04/2014 at 19:37. Pushed by nienhueser into branch 'master'. KML tag writer for NetworkLinkControl REVIEW: 117343 M +2 -0 src/lib/marble/geodata/CMakeLists.txt M +1 -1 src/lib/marble/geodata/handlers/kml/KmlLinkSnippetTagHandler.cpp M +2 -1 src/lib/marble/geodata/handlers/kml/KmlNetworkLinkControlTagHandler.cpp A +54 -0 src/lib/marble/geodata/writers/kml/KmlNetworkLinkControlTagWriter.cpp [License: LGPL] A +27 -0 src/lib/marble/geodata/writers/kml/KmlNetworkLinkControlTagWriter.h [License: LGPL] A +35 -0 src/lib/marble/geodata/writers/kml/KmlUpdateTagWriter.cpp [License: LGPL] A +27 -0 src/lib/marble/geodata/writers/kml/KmlUpdateTagWriter.h [License: LGPL] A +16 -0 tests/data/NetworkLinkControl.kml http://commits.kde.org/marble/d9299ef70122fc9f6debc4d5715ac2f712cf9c79 |
Marble has KML tag handlers to parse <NetworkLinkControl> and related child tags, which are represented in a GeoDataNetworkLinkControl. Add a KML tag writer for <NetworkLinkControl> to write back the values. - Add KmlNetworkLinkControlTagWriter.{h,cpp} to src/lib/marble/geodata/writers/kml/, implement it and add it to CMakeLists.txt in src/lib/marble/geodata/ - Add NetworkLinkControl.kml to tests/data/ See https://developers.google.com/kml/documentation/kmlreference?#networklinkcontrol for reference and examples. Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestGeoDataWriter and make sure no errors come up. Use tools/kml2kml to analyze errors and fix the tag writers, if needed. Submit a review request at https://git.reviewboard.kde.org with the marble group as reviewers. Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.