Summary: | Calligra words crash upon file open. | ||
---|---|---|---|
Product: | [Applications] calligrawords | Reporter: | Martin Bednar <martin+kde> |
Component: | general | Assignee: | Pierre Ducroquet <pinaraf> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | cbo, inge, philipz85, pinaraf |
Priority: | NOR | Keywords: | drkonqi |
Version: | 2.8.0 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/389745aa2e2a5ceb0de79b7e03150d3d65cf4bc5 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: |
crashing file
New crash information added by DrKonqi Work around this crash (no line for the anchor position is found) Smallest test case possible... |
Description
Martin Bednar
2014-03-16 17:00:42 UTC
Hi Martin, and thanks for the bug report. Yes, a file that makes Words crash would help fixing this bug significantly. We have tested the comments quite a lot so I doubt that it's that only that does it. It could be the combination with tracked changes or something else. Created attachment 85634 [details]
crashing file
Created attachment 86960 [details] New crash information added by DrKonqi calligrawords (2.8.0) on KDE Platform 4.12.3 using Qt 4.8.1 - What I was doing when the application crashed: Was attempting to open the file found with https://bugs.freedesktop.org/attachment.cgi?id=93106 -- Backtrace (Reduced): #7 0xb6ce0bd3 in QTextLine::y() const () from /usr/lib/i386-linux-gnu/libQtGui.so.4 #8 0xb61a1079 in KoTextDocumentLayout::positionAnchorTextRanges(int, int, QTextDocument const*) () from /usr/lib/libkotextlayout.so.13 #9 0xb61868e7 in KoTextLayoutArea::layoutBlock(FrameIterator*) () from /usr/lib/libkotextlayout.so.13 #10 0xb618953c in KoTextLayoutArea::layout(FrameIterator*) () from /usr/lib/libkotextlayout.so.13 #11 0xb619e6f9 in KoTextLayoutRootArea::layoutRoot(FrameIterator*) () from /usr/lib/libkotextlayout.so.13 Created attachment 88795 [details]
Work around this crash (no line for the anchor position is found)
obviously guarding like this is a good - but i am wondering if we see the correct result or if we should look deeper I am still trying to simplify the document while still reproducing the crash so I could understand what goes really wrong here. This preliminary patch is just to say «hey, look here, I'm buggy» while crying «fix me, fix me» :) Created attachment 88841 [details]
Smallest test case possible...
This new test case is an heavily stripped down version of the first submitted test case for this bug.
It contains what is needed to create the crash, nothing more :
Styles => default for all paragraphs : fo:line-height="100%"
Content => paragraph over a few lines then a span containing an annotation with a text:p and a piece of text after the annotation in the span
Git commit 389745aa2e2a5ceb0de79b7e03150d3d65cf4bc5 by Pierre Ducroquet. Committed on 25/09/2014 at 22:05. Pushed by ducroquet into branch 'master'. Don't look further than what we are currently layouting This code was off by one and tried to look for anchors after the line current layouting. Testing done on : - the two test cases for bug 332220 : no more crash, comment still visible. - a simple non-crashing file : no crash, comment still visible. REVIEW: 120375 M +1 -1 libs/textlayout/KoTextDocumentLayout.cpp http://commits.kde.org/calligra/389745aa2e2a5ceb0de79b7e03150d3d65cf4bc5 even though i reverted the fix i can't reproduce the crash either - so keeping the bug closed |