Bug 332214

Summary:	File properties dialog is populated incorrectly for results in the tags:/ KIO
Product:	[Frameworks and Libraries] frameworks-baloo	Reporter:	Elias Probst <mail>
Component:	Tags	Assignee:	Pinak Ahuja <pinak.ahuja>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arthur, aspotashev, nate, noein93, pinak.ahuja
Priority:	NOR
Version First Reported In:	5.20.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	https://commits.kde.org/baloo/16664fccb7b7a92b910ca479d0ee227a72e44787	Version Fixed/Implemented In:
Sentry Crash Report:

Description Elias Probst 2014-03-16 14:44:04 UTC

How to reproduce:
→ List some files using the tags:/ KIO slave
→ Rightclick on one of them
→ Properties

1. The window title shows the full file path but wrongly encoded (e.g. _2Fhome_2Felias_2FTODOs) instead of just the filename (e.g. TODOs)
2. The filename field shows the full file path but wrongly encoded (e.g.  _2Fhome_2Felias_2FTODOs) instead of just the filename (e.g. TODOs)
3. The "Location:" is shown as the tag-path (e.g. /fooo/fooo (tags)) instead of the file's actual location in the filesystem (e.g. /home/elias)
4. The preview tab shows nothing (compared to looking at the preview of the same file using the regular file:/ KIO) which is probably caused by the "messed up" file URL.

Comment 1 Vishesh Handa 2014-03-16 15:05:42 UTC

Yes. I know about this problem. I'll try to fix it in a proper way later.

Comment 2 Alexander Potashev 2016-03-20 10:38:21 UTC

> 1. The window title shows the full file path but wrongly encoded (e.g. _2Fhome_2Felias_2FTODOs) instead of just the filename (e.g. TODOs)
> 2. The filename field shows the full file path but wrongly encoded (e.g.  _2Fhome_2Felias_2FTODOs) instead of just the filename (e.g. TODOs)

I confirm this with Baloo-5.20.

Comment 3 Jamie Smith 2017-11-29 19:04:15 UTC

Git commit 16664fccb7b7a92b910ca479d0ee227a72e44787 by James D. Smith.
Committed on 29/11/2017 at 19:04.
Pushed by smithjd into branch 'master'.

Strip down and re-write the baloo tags KIO slave

Summary:
Allow for more operations on tag trees (e.g. rename, copy, delete) and fix some existing issues.
Related: bug 314373, bug 340098, bug 376229, bug 340099

Reviewers: #frameworks, vhanda, #dolphin, ngraham, dfaure

Reviewed By: ngraham, dfaure

Subscribers: anthonyfieroni, dfaure, nicolasfella, ngraham

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D8098

M  +339  -305  src/kioslaves/tags/kio_tags.cpp
M  +29   -14   src/kioslaves/tags/kio_tags.h
M  +6    -6    src/kioslaves/tags/tags.protocol

https://commits.kde.org/baloo/16664fccb7b7a92b910ca479d0ee227a72e44787