| Summary: | Unsharp mask acts as blur in the filter paintop. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Paul Geraskin <paulgeraskin> |
| Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, garbi75, halla |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/13657911836f1996de6154b305386c3e72944c34 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Paul Geraskin
2014-03-14 10:14:36 UTC
Hm, if I just create a preset from scratch for gauss blur or unsharp mask, the filter brush just works. Could it just be an incompatibility in the settings? Dmitry confirmed that he has the same issue on his machine. And if you _don't_ use that preset? But go to the brush editor, select filterop, select gauss blur or unsharp mask and make sure the settings do something? The default settings for unsharp mask all seem to be zero. Out of the box, the fx_blur_light preset uses blur. If I select gauss blur when that preset is active, the radius is 0.5. I guess that that doesn't do much. Same for unsharp mask, where it's all 0. Ok i did it: - Pressed "Default Preset" - Selected Filter Brush - Choosen Unsharpen Mask filter Brush works like Blur filter. It blurs. But it should sharpen. Here is screenshot: http://i.imgur.com/ptbMKL4.png Possibly, new filter is not switched when we make a new choose. Yes, _that_ I can confirm. Fixed the subject. It isn't that the filter isn't switched, though -- check with some other filters. Pixelize, Invert and others filters works ok. Noize filter - crash. I think GaussianBlur and UnsharpenMask should be checked. I noticed this irritating bug with bad acting of brushes that use sharpen or blur as well. Could it be fixed soon and in what release? There was Krita v2.8.1 released recently, but the (above described) bug remains... :( Yes... There'll always be bugs that won't be fixed in time for the next version... OK, I can understand, but could you let me know when this bug will be corrected, anyway? 2014-04-07 10:10 GMT+02:00 Boudewijn Rempt <boud@valdyas.org>: > https://bugs.kde.org/show_bug.cgi?id=332130 > > --- Comment #11 from Boudewijn Rempt <boud@valdyas.org> --- > Yes... There'll always be bugs that won't be fixed in time for the next > version... > > -- > You are receiving this mail because: > You are on the CC list for the bug. It might be some transaction-related problem, which prevents Unsharp Mask accessing oldRawData Git commit 5b3de8cc8ca6d58f0ef8d131c5ef3ff40c32416c by Dmitry Kazakov. Committed on 05/05/2014 at 08:50. Pushed by dkazakov into branch 'master'. Fix using a transaction in the Filter Op Otherwise the filters like Gaussian Blur and Unsharp Mask will not work correctly. M +4 -0 krita/plugins/paintops/filterop/kis_filterop.cpp http://commits.kde.org/calligra/5b3de8cc8ca6d58f0ef8d131c5ef3ff40c32416c Well, I didn't find it fixed in latest bugfix version (v2.8.3) but I hope I will see it in 2.8.5 or 2.9! :P 2014-05-05 10:50 GMT+02:00 Dmitry Kazakov <dimula73@gmail.com>: > https://bugs.kde.org/show_bug.cgi?id=332130 > > Dmitry Kazakov <dimula73@gmail.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|CONFIRMED |RESOLVED > Resolution|--- |FIXED > Latest Commit| |http://commits.kde.org/call > | |igra/5b3de8cc8ca6d58f0ef8d1 > | |31c5ef3ff40c32416c > > --- Comment #14 from Dmitry Kazakov <dimula73@gmail.com> --- > Git commit 5b3de8cc8ca6d58f0ef8d131c5ef3ff40c32416c by Dmitry Kazakov. > Committed on 05/05/2014 at 08:50. > Pushed by dkazakov into branch 'master'. > > Fix using a transaction in the Filter Op > > Otherwise the filters like Gaussian Blur and Unsharp Mask will not work > correctly. > > M +4 -0 krita/plugins/paintops/filterop/kis_filterop.cpp > > http://commits.kde.org/calligra/5b3de8cc8ca6d58f0ef8d131c5ef3ff40c32416c > > -- > You are receiving this mail because: > You are on the CC list for the bug. Git commit 13657911836f1996de6154b305386c3e72944c34 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 05/05/2014 at 08:50. Pushed by rempt into branch 'calligra/2.8'. Fix using a transaction in the Filter Op Otherwise the filters like Gaussian Blur and Unsharp Mask will not work correctly. M +4 -0 krita/plugins/paintops/filterop/kis_filterop.cpp http://commits.kde.org/calligra/13657911836f1996de6154b305386c3e72944c34 |
