Bug 331532

Summary:	Extend unit test KML files to cover various KML Style tags
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	Cruceru Calin-Cristian <crucerucalincristian>
Status:	RESOLVED FIXED
Severity:	task	CC:	crucerucalincristian, savita.seetaraman5
Priority:	NOR	Keywords:	junior-jobs
Version:	1.8 (KDE 4.13)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/d8bea157f55d72abd762b7a41e69b2a2e7492c2b	Version Fixed In:
Sentry Crash Report:

Description Dennis Nienhüser 2014-02-26 12:27:37 UTC

In KML various *Style tags can be used to specify the rendering of elements. See examples/kml/germany.kml in Marble's sources for some examples and the KML reference at https://developers.google.com/kml/documentation/kmlreference

Marble has tag handlers and tag writers for parsing and writing these tags, but the unit tests currently do not cover them appropriately. Extend the .kml files in tests/data/ to include at least one tag for each with non-default values of
- BalloonStyle
- ColorStyle
- IconStyle
- LineStyle
- ListStyle
- PolyStyle

Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestGeoDataWriter and make sure no errors come up. Use tools/kml2kml to analyze errors and fix the tag writers, if needed. Submit a review request at https://git.reviewboard.kde.org with the marble group as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.

Comment 1 Savita 2014-02-26 13:33:26 UTC

I want to work on this.

Comment 2 Dennis Nienhüser 2014-03-07 16:34:02 UTC

No action, unassigned.

Comment 3 Cruceru Calin-Cristian 2014-03-07 16:39:07 UTC

I will work on this.

Comment 4 Dennis Nienhüser 2014-03-13 18:48:36 UTC

Git commit d8bea157f55d72abd762b7a41e69b2a2e7492c2b by Dennis Nienhüser, on behalf of Cruceru Calin-Cristian.
Committed on 13/03/2014 at 18:47.
Pushed by nienhueser into branch 'master'.

Extend unit test KML files to cover various KML Style tags

REVIEW: 116702

M  +4    -2    tests/data/ListStyleTest1.kml
M  +6    -1    tests/data/ListStyleTest2.kml
M  +1    -0    tests/data/MackyModel.kml
M  +1    -1    tests/data/NetworkLinkDocument.kml

http://commits.kde.org/marble/d8bea157f55d72abd762b7a41e69b2a2e7492c2b