Bug 331410

Summary: very weird issue when changing rotation sensors on Block_bristles preset
Product: [Applications] krita Reporter: animtim
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: dimula73
Priority: NOR    
Version: 2.8 Beta   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/473baa4a7e0aca8dcc71ab9d4ebcbd422ed30fd1 Version Fixed In:
Sentry Crash Report:

Description animtim 2014-02-22 14:44:18 UTC 
After selecting Block_bristles preset, changing active sensor on the Rotation parameter makes pressure value mixed in rotation. That is a bad bug.

I could only reproduce it with this exact preset from default (some user-presets may have the issue too). With every other default presets using rotation sensors, I couldn't reproduce the problem, everything seems to be fine.

Note: it happens on 2.8 branch, but probably on master too (though it would need confirmation that it's in master too)


Reproducible: Always

Steps to Reproduce:
1.Select Block_bristles preset
2.in the preset editor, in the rotation sensors tab, activate Ascension (or Distance, I tested it can happen with it too, probably happens with others too but hard to check with all..) and desactivate Drawing angle
3.draw something: see the rotation change depending on pressure
(also you can see the brush outline it always reset to 0° on hover instead of following ascension rotation, that's another way to notice the problem)
Comment 1 Dmitry Kazakov 2014-03-01 05:31:13 UTC 
In this commit the bug is *not* present: 8bd7c3445367438d274613b
Comment 2 Dmitry Kazakov 2014-03-01 06:48:45 UTC 
commit f5aa69e113cd0fc097ff79 is also bugfree
Comment 3 Dmitry Kazakov 2014-03-01 08:47:16 UTC 
e7757fb96dea100c996e8f is also bugfree
Comment 4 Dmitry Kazakov 2014-03-01 09:26:45 UTC 
56a29e66b02fee4367c4f is bugfree
Comment 5 Dmitry Kazakov 2014-03-01 09:40:02 UTC 
75ff90605843a3d995ba6 already has a bug

The bug appeared between commits e7757fb96dea100c996e8f and 56a29e66b02fee4367c4f
Comment 6 Dmitry Kazakov 2014-03-04 11:33:49 UTC 
The failing commit is: 2f43a931c934c505f5ad652c00d21fba4e4d
Comment 7 Dmitry Kazakov 2014-03-05 10:54:01 UTC 
Git commit 473baa4a7e0aca8dcc71ab9d4ebcbd422ed30fd1 by Dmitry Kazakov.
Committed on 05/03/2014 at 10:53.
Pushed by dkazakov into branch 'master'.

Fix weird behavior of the older-type presets

We should not disable all the sensors of the preset just because its
curve is of old style. This activates Pressure sensor implicitly, which
is not what we really want.

M  +0    -2    krita/plugins/paintops/libpaintop/kis_curve_option.cpp

http://commits.kde.org/calligra/473baa4a7e0aca8dcc71ab9d4ebcbd422ed30fd1