Summary: | Most apps are not listed | ||
---|---|---|---|
Product: | [Applications] muon | Reporter: | Jonathan Riddell <jr> |
Component: | discover | Assignee: | Aleix Pol <aleixpol> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aleixpol, sitter |
Priority: | NOR | ||
Version: | 2.1.70 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/muon/3a9d2769b6ce8b8ec1b25d5db2782dd004fe7d7d | Version Fixed In: |
Description
Jonathan Riddell
2014-02-21 11:17:48 UTC
Same in muon-installer, so this likely is a problem with the models. This can't be reproduced in 13.10. I'll need some more information... :/ Perhaps kdelibs broke? offending commit is f9931c3d841ccb215a3bad14e0adc9dddb84091c it introduces the following change: - QString categories = getField("Categories"); + QStringList categories = QString(getField("Categories")).split(',', QString::SkipEmptyParts); which in turn leads to the proxy model refusing to apply category filters: muon-discover(12215) shouldFilter: "KPatience" muon-discover(12215) shouldFilter: "Qt;KDE;Game;CardGame;" muon-discover(12215) shouldFilter: CategoryFilter false So, either that change was wrong to begin with, or kdelibs changed behavior. Categories as per the spec is a ; seperated list, however I seem to recall that the previous thing we used in KDE had , as seperator (might be utterly unrelated :P). The question is, does it actually return "Foo,Bar" on kdelibs 4.11, if so then I guess kdelibs should get fixed. ah, fwiw, the commit is in muon, I did not look for any related changes in kdelibs. Ah yes, that did change. I'll have to try it again then, maybe I looked the wrong way...? PS: I should add tests for that! Git commit 635479c77dc76be3c3cfcd71aa405ef7fc128bc6 by Aleix Pol. Committed on 01/03/2014 at 20:12. Pushed by apol into branch '2.2'. Split categories This API changed over this summer, it wasn't properly ported. M +2 -2 libmuon/backends/ApplicationBackend/Application.cpp http://commits.kde.org/muon/635479c77dc76be3c3cfcd71aa405ef7fc128bc6 Git commit 3a9d2769b6ce8b8ec1b25d5db2782dd004fe7d7d by Jonathan Riddell. Committed on 04/03/2015 at 16:19. Pushed by jriddell into branch 'Plasma/5.2'. Add back patch for bug 331374 App categories do not work Related: bug 344831 M +2 -2 libmuon/backends/ApplicationBackend/Application.cpp http://commits.kde.org/muon/3a9d2769b6ce8b8ec1b25d5db2782dd004fe7d7d |