| Summary: | Rotation: Brush Option Does Not Read From Tablet | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Benjamin Slack <iam> |
| Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | dimula73, halla, xb_creations |
| Priority: | NOR | ||
| Version: | 2.8 Beta | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | http://commits.kde.org/calligra/1a24a4dc26c905ae011ec0dd174cbae737169aeb | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Log from Krita Session using Tablet and Artpen
Patch that should fix the rotation sensor on Windows New rotation patch for both Windows and Linux Newer rotation patch with a crash fixed on Linux Fourth version of the patch that fixes a crash on Linux |
||
|
Description
Benjamin Slack
2014-02-21 03:23:00 UTC
Hi, Benjamin! Thank you very much for your report! This problem is really important for us. Could you please generate and attach the tablet events log, so we could see what is happening there? To do this you need to: 0) Install DebugView app (http://technet.microsoft.com/en-us/sysinternals/bb896647.aspx) and run it 1) Open any image in Krita 2) Press Ctrl+Shift+T (you'll see a message telling the logging is activated) 3) Paint with the rotation-capable stylus 4) Attach the output generated in DebugView Hm, we had the same report before. But the only artpen the project has is with Lukas, who recently became a father and hasn't got a lot of time :-( I'm tempted to just get one for the cintiq wacom donated recently so we can test. Okay, I ordered a new art pen :-) Created attachment 85275 [details]
Log from Krita Session using Tablet and Artpen
Sorry about the delay, see attached log as requested.
Yes, I recently got an art marker as well, and I can confirm the issues. See also http://forum.kde.org/viewtopic.php?f=137&t=119319&p=302891#p302891 This is a repost from the link above: rotation feature with the latest build so far (2.7.9.11): Rotation is recognized, but: 1- The tip rotates like crazy even when I am not moving the stylus at all. This is fixed by moving the percentage slider all the way to 0.1%, and then I notice that the rotation goes towards the opposite direction. Logically this can be easily solved by manipulating the curve. But: 2- If I change the curve in any way, krita stops recognizing stylus rotation unless I restart the program. This happens only for the specific feature I changed. For example: I have rotation set to "rotation", I change the curve and it stops working for the rest of the session. But if I go to size and set it to rotation, it works - except if I change the curve here as well. Here is the problem piece of code:
virtual qreal value(const KisPaintInformation& info) {
return info.rotation() / 28 + 0.5; // it appears that rotation is between -14 and +14
}
And for this very device the resolution of the rotation is 400+. I need to find out how to get a real rotational resolution.
Created attachment 85314 [details]
Patch that should fix the rotation sensor on Windows
This patch should fix the rotational sensor on Windows. I have no rotation-capable device, so please someone test it :)
Created attachment 85315 [details]
New rotation patch for both Windows and Linux
This new patch should fix the rotation on both Windows and Linux platforms
Created attachment 85316 [details]
Newer rotation patch with a crash fixed on Linux
I can test it but I am not sure where to paste this piece of code (windows) (In reply to comment #8) > Created attachment 85314 [details] > Patch that should fix the rotation sensor on Windows > > This patch should fix the rotational sensor on Windows. I have no > rotation-capable device, so please someone test it :) Created attachment 85317 [details]
Fourth version of the patch that fixes a crash on Linux
Happy to test any patches, but don't have the capacity to build here. Point me at a binary and I'll give it a shot. I tested the patch, and the behaviour is fixed on Linux, but not on Windows. Dmitry and I need to sit together with our stock of test tablets to fix it, so that'll be May, during the Krita sprint. Ok, this bug awaits for a fix on Windows. We'll take a look at it during the sprint. Git commit d38ce2cbfeac38bfdaae42548f77e89fda63cb4e by Dmitry Kazakov. Committed on 12/05/2014 at 11:58. Pushed by dkazakov into branch 'master'. Fix tablet stylus rotation on Linux The Windows part will be fixed during the upcoming sprint. M +1 -1 krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensors.h M +3 -1 krita/ui/input/wintab/kis_tablet_support.h M +9 -1 krita/ui/input/wintab/kis_tablet_support_win.cpp M +6 -2 krita/ui/input/wintab/kis_tablet_support_x11.cpp http://commits.kde.org/calligra/d38ce2cbfeac38bfdaae42548f77e89fda63cb4e Git commit d739dc5c256affcbf085e2734c67c7be501b9e3d by Dmitry Kazakov. Committed on 22/05/2014 at 16:14. Pushed by dkazakov into branch 'master'. Fixed rotation tablet sensor on Windows Wintab returns bogus resolution for rotation so just use standard values instead M +2 -0 krita/ui/input/wintab/kis_tablet_support.h M +3 -7 krita/ui/input/wintab/kis_tablet_support_win.cpp http://commits.kde.org/calligra/d739dc5c256affcbf085e2734c67c7be501b9e3d Git commit 97f30c7d6cc7cbc940ad7d8eefc94d42fbd1f7fd by Dmitry Kazakov. Committed on 22/05/2014 at 16:28. Pushed by dkazakov into branch 'master'. Make rotation on Linux be consistent with rotation on Windows Yeah, the two drivers return really different values :) Even the axes are laid out in opposite directions. M +21 -26 krita/ui/input/wintab/kis_tablet_support_x11.cpp http://commits.kde.org/calligra/97f30c7d6cc7cbc940ad7d8eefc94d42fbd1f7fd Git commit cc5b3c1a580720855a26c33baf6fba94c07ddbee by Dmitry Kazakov. Committed on 30/05/2014 at 14:52. Pushed by dkazakov into branch 'master'. Fix artifacts when rotation stylus sensor is activated The angular stylus function is wrapped nead 2 * pi point so we should use a bit more complicated algorithm to fix handle it M +11 -1 krita/image/brushengine/kis_paint_information.cc M +9 -0 krita/image/kis_global.h http://commits.kde.org/calligra/cc5b3c1a580720855a26c33baf6fba94c07ddbee Git commit 543482d4677d68e91236fd0aeaf3d9020399202e by Dmitry Kazakov. Committed on 12/05/2014 at 11:58. Pushed by dkazakov into branch 'calligra/2.8'. Fix tablet stylus rotation on Linux The Windows part will be fixed during the upcoming sprint. M +1 -1 krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensors.h M +3 -1 krita/ui/input/wintab/kis_tablet_support.h M +9 -1 krita/ui/input/wintab/kis_tablet_support_win.cpp M +6 -2 krita/ui/input/wintab/kis_tablet_support_x11.cpp http://commits.kde.org/calligra/543482d4677d68e91236fd0aeaf3d9020399202e Git commit 1a24a4dc26c905ae011ec0dd174cbae737169aeb by Dmitry Kazakov. Committed on 22/05/2014 at 16:28. Pushed by dkazakov into branch 'calligra/2.8'. Make rotation on Linux be consistent with rotation on Windows Yeah, the two drivers return really different values :) Even the axes are laid out in opposite directions. M +21 -26 krita/ui/input/wintab/kis_tablet_support_x11.cpp http://commits.kde.org/calligra/1a24a4dc26c905ae011ec0dd174cbae737169aeb |