| Summary: | Dutch Koningsdag | ||
|---|---|---|---|
| Product: | [Applications] kdepimlibs | Reporter: | Manuel Stol <ManuelStol> |
| Component: | kholidays | Assignee: | John Layt <jlayt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdepim-bugs |
| Priority: | NOR | ||
| Version: | GIT (master) | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | All | ||
| Latest Commit: | Version Fixed In: | 4.14 | |
| Sentry Crash Report: | |||
Fixed for 4.14. Unfortunately I couldn't get the parser to take a "previous" option, it uses some bit-shifting magic in the calculation which I couldn't make go backwards, so I had to use a more complex conditional rule. But at least it's correct now :-) Git commit 83b22e17ca24c7441523d3d15a92d3408471875c by John Layt. Committed on 20/06/2014 at 22:02. Pushed by jlayt into branch 'master'. Change Koningsdag in Netherlands holiday file The Netherlands now has a King so change form Queen's Day to King's Day, as well as fixing the shift rule. M +8 -1 kholidays/holidays/plan2/holiday_nl_nl http://commits.kde.org/kdepimlibs/83b22e17ca24c7441523d3d15a92d3408471875c |
Since 01-01-2014 the Koninginnedag holiday (Queen's day) has been changed to Koningsdag (King's day). In libkholidays/plan1/holiday_nl_nl and in libkholidays/plan2/holiday_nl_nl change the line: "Koninginnedag" weekend on april 30 shift to monday if sunday into: "Koningsdag" weekend on april 27 Request to support not only "shift to" but also "shift downto" in kholidays. When kholidays supports "shift downto", change the Koningsdag holiday to: "Koningsdag" weekend on april 27 shift downto saturday if sunday Notes: - The date for Koninginnedag is wrong. If April 30 fall on a Sunday, Koninginnedag shifts to Saturday April 26 since 1980. It did shift to the following Monday before 1980. However, kholidays does not support shifting downwards. - The date for the Koningsday should shift to Saterday April 26, if April 27 falls on a Sunday. However, kholidays does not support shifting downwards. - See: http://en.wikipedia.org/wiki/Koningsdag Thank you, Manuel