| Summary: | Hardcoded shellDirs in plasma-framework/src/shell/shellmanager.cpp | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Hrvoje Senjan <hrvoje.senjan> |
| Component: | general | Assignee: | Ivan Čukić <ivan.cukic> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | ||
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-framework/dde1da619e94001391697d55edeb3df54d43bb37 | Version Fixed In: | |
| Sentry Crash Report: | |||
Ivan, I think you wrote that code, any particular reason for not using QStandardPaths? I copied it from somewhere else in plasma. Thought there was a reason for not using QSP :) Git commit dde1da619e94001391697d55edeb3df54d43bb37 by Hrvoje Senjan. Committed on 19/02/2014 at 11:15. Pushed by hrvojes into branch 'master'. Use QStandardPaths for finding plasma shells instead of hardcoding to install prefix Otherwise plasma shells are never found if plasma-framework and kde-workspace are installed to different prefixes REVIEW: 115871 M +3 -2 src/shell/shellmanager.cpp http://commits.kde.org/plasma-framework/dde1da619e94001391697d55edeb3df54d43bb37 |
static const QString s_shellsDir( QString(CMAKE_INSTALL_PREFIX) + "/" + DATA_INSTALL_DIR + "/" + "plasma/shells/"); So if you install plasma-framework in prefix 'a' and kde-workspace in prefix 'b', you'll get "We have no shell handlers installed" Reproducible: Always