Bug 330995

Summary:	Memory leaks
Product:	[Applications] kiten	Reporter:	Maximiliano Curia <maxy>
Component:	general	Assignee:	Joseph Kerian <jkerian>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
Latest Commit:	http://commits.kde.org/kiten/390d5febfb7e8e35727346d57a423901ff35a595	Version Fixed In:
Sentry Crash Report:
Attachments:	Deinflection::search leaks DictFileEdict::doSearch leaks DictFileKanjidic::doSearch leaks KanjiBrowser::loadKanji leaks RadicalFile::loadRadicalFile leaks

Description Maximiliano Curia 2014-02-10 21:24:49 UTC

Hi,

I've tested running kiten with valgrind and found a number of memory leaks, this bug was originally reported in the Debian bug tracker here:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737594

I'm attaching some patches for the most obvious leaks reported by valgrind.

Thanks,

Reproducible: Always

Steps to Reproduce:
1. valgrind --trace-children=yes --log-file=/tmp/kiten.%p --leak-check=full --track-origins=yes kiten


Expected Results:  
No memory leaks were detected.

Comment 1 Maximiliano Curia 2014-02-10 21:26:05 UTC

Created attachment 85086 [details]
Deinflection::search leaks

Comment 2 Maximiliano Curia 2014-02-10 21:26:54 UTC

Created attachment 85087 [details]
DictFileEdict::doSearch leaks

Comment 3 Maximiliano Curia 2014-02-10 21:27:34 UTC

Created attachment 85088 [details]
DictFileKanjidic::doSearch leaks

Comment 4 Maximiliano Curia 2014-02-10 21:28:12 UTC

Created attachment 85089 [details]
KanjiBrowser::loadKanji leaks

Comment 5 Maximiliano Curia 2014-02-10 21:28:40 UTC

Created attachment 85090 [details]
RadicalFile::loadRadicalFile leaks

Comment 6 Andreas Cord-Landwehr 2014-02-25 18:30:57 UTC

Git commit 390d5febfb7e8e35727346d57a423901ff35a595 by Andreas Cord-Landwehr, on behalf of Maximiliano Curia.
Committed on 25/02/2014 at 18:28.
Pushed by cordlandwehr into branch 'master'.

Fix memory leaks.

This fixes a set of memory leaks as reported in Debian bugs
610534 and 737594.
CCMAIL: maxy@debian.org
REVIEW: 115988

M  +4    -1    kanjibrowser/kanjibrowser.cpp
M  +5    -1    lib/DictEdict/deinflection.cpp
M  +6    -0    lib/DictEdict/dictfileedict.cpp
M  +1    -0    lib/DictKanjidic/dictfilekanjidic.cpp
M  +1    -0    radselect/radicalfile.cpp

http://commits.kde.org/kiten/390d5febfb7e8e35727346d57a423901ff35a595