Summary: | Konsole opens bash after kdevelop_attach even if zsh is set. | ||
---|---|---|---|
Product: | [Applications] kdevelop | Reporter: | alexander.hermans0 |
Component: | general | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | diadlo, egorov, kfunk, octoploid, tmn |
Priority: | NOR | Keywords: | junior-jobs |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 5.1.0 | |
Attachments: |
zsh support patch for kdevplatform
zsh support patch for kdevelop |
Description
alexander.hermans0
2014-01-29 13:09:41 UTC
It loads zsh for me. How did you change your default shell? I changed the /etc/passwd/ entry for my user to /bin/zsh. KDevelop use it own addition for bash environment (`.bashrc`). I'm not sure, that it will work right in another shell You can find it in the `kdevplatform_shell_environment.sh` file, in directory, where stored kdevelop! `whereis kdevelop\!` There was some attempt to add zsh support some years ago: https://git.reviewboard.kde.org/r/110298/diff/3/ Feel free to pick up those patches and rebase & test them once more, then we'll have these merged. Any takers? Created attachment 101796 [details]
zsh support patch for kdevplatform
Created attachment 101797 [details]
zsh support patch for kdevelop
The patches are attached. Works fine for me.
It is a bit ugly that .zshrc gets installed in /usr/bin.
Maybe it should live somewhere else?
It'd be better to have these patches on either ReviewBoard or Phabricator so we could discuss the diff. (In reply to Kevin Funk from comment #8) > It'd be better to have these patches on either ReviewBoard or Phabricator so > we could discuss the diff. It is just a rough rebase. I have only tested it in a very limited way. Split open doesn't work for example: markus@x4 ~ % cat test.zsh RESULT=$(qdbus org.kdevelop.kdevelop-30695 /org/kdevelop/DocumentController org.kdevelop.DocumentController.openDocumentsSimple $1 ) if [[ "$RESULT" != "true" ]]; then echo "Failed to open $1" && exit 1 fi echo "OK" markus@x4 ~ % bash test.zsh "( /home/markus/bench.cpp - /home/markus/hello.cpp )" OK markus@x4 ~ % zsh test.zsh "( /home/markus/bench.cpp - /home/markus/hello.cpp )" Failed to open ( /home/markus/bench.cpp - /home/markus/hello.cpp ) Not sure what is going on. So this needs more testing before it can be officially proposed. Patches pushed. https://phabricator.kde.org/D3171 (kdevplatform) https://phabricator.kde.org/D3172 (kdevelop) Thanks for the patches! |