Bug 330400

Summary: Opening *.Kpp open a dialog 'Missing Filter' with a list of fileformat
Product: [Applications] krita Reporter: David REVOY <info>
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla, kossebau
Priority: NOR    
Version: 2.8 Beta   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description David REVOY 2014-01-25 17:16:21 UTC
Hi, 
*.kpp can't be edited saved ; and show a 'Missing Filter' dialog. 
( right click on the file in Nautilus, then 'open with' / or D&D on Krita canvas / or by open menu )

The fix
======
Found by Frinring yesterday on IRC : adding :

<sub-class-of="image/png"/>

at l.11 in krita/data/krita.xml , fix the issue ; KPP can be opened, and saved directly. 
( Note : this bug might be Gnome Desktop specific , as it was confirmed by Vasco_B  )
Comment 1 Halla Rempt 2014-02-06 14:36:34 UTC
Git commit 91474a500c0776e95d17b4b95ff6d13642ebdd9c by Boudewijn Rempt.
Committed on 06/02/2014 at 14:36.
Pushed by rempt into branch 'calligra/2.8'.

M  +1    -0    krita/data/krita.xml

http://commits.kde.org/calligra/91474a500c0776e95d17b4b95ff6d13642ebdd9c
Comment 2 Halla Rempt 2014-02-06 14:36:50 UTC
Git commit 842dd8458d792038cbf91e30bbe61f497d36ed24 by Boudewijn Rempt.
Committed on 06/02/2014 at 14:36.
Pushed by rempt into branch 'master'.

M  +1    -0    krita/data/krita.xml

http://commits.kde.org/calligra/842dd8458d792038cbf91e30bbe61f497d36ed24
Comment 3 Friedrich W. H. Kossebau 2014-02-12 19:33:44 UTC
<sub-class-of="image/png"/> was the first proposal to try, later corrected to the <sub-class-of type="image/png"/> :) So needs fixing, current entry is wrong (as can be also seen by the error on installing.

But that entry was just a proposal to try from me, did not test it myself. Until now, and do not see it working.

Deevad, could you give this another check? What does really work for you?
Comment 4 David REVOY 2014-02-12 21:34:42 UTC
>> Deevad, could you give this another check? What does really work for you?
Hey :) the actual commit made by Boud ( I think what you describe by 'current' ) works for me here ; I'm redoing all preview of a brushkit with 2.8git so, it's being tested.  ( Gnome 3.10, Ubuntu 13.10 , Linux 3.11.0-15 , Nvidia 319.32 , Xorg 1.14.5 , KDEdev 4.11.3, Qt 4.8.4 )
Comment 5 Friedrich W. H. Kossebau 2014-02-12 21:48:52 UTC
Hm. Problem ist that this is broken xml, so the mimetype installer will ignore the current file. Could you please tell what you have in your $INSTALL_BASE_DIR/share/mime/application/x-krita-paintoppreset.xml ?
Comment 6 David REVOY 2014-02-13 08:34:00 UTC
Opps, my $INSTALL_BASE_DIR(where Krita is installed)/share/mime/application/ folder is empty. 
on /usr/share/mime/application/ I have an entry for Krita *.kra , but not one for x-krita-paintoppreset.xml
and with a locate --f x-krita-paintoppreset.xml  , I found only /home/deevad/.local/share/Trash/files/share.2/mime/application/x-krita-paintoppreset.xml  ; certainly coming from a previous installation put to trash on my reinstall a month ago.
Comment 7 Halla Rempt 2014-02-13 09:15:28 UTC
Git commit be0511675d63334783fb32eaf627d1b93f06f76d by Boudewijn Rempt.
Committed on 13/02/2014 at 08:48.
Pushed by rempt into branch 'calligra/2.8'.

Fix XML

It still doesn't work, though.

M  +1    -1    krita/data/krita.xml

http://commits.kde.org/calligra/be0511675d63334783fb32eaf627d1b93f06f76d
Comment 8 Halla Rempt 2014-02-14 08:11:08 UTC
Git commit 391508c2b98918514700fa21ad4a81ee258282d6 by Boudewijn Rempt.
Committed on 13/02/2014 at 08:48.
Pushed by rempt into branch 'master'.

Fix XML

It still doesn't work, though.

M  +1    -1    krita/data/krita.xml

http://commits.kde.org/calligra/391508c2b98918514700fa21ad4a81ee258282d6
Comment 9 Halla Rempt 2014-02-18 11:14:22 UTC
Git commit f12c54f30fd8dfcbd0252ed8f116d095af986129 by Boudewijn Rempt.
Committed on 18/02/2014 at 10:42.
Pushed by rempt into branch 'master'.

M  +1    -0    libs/main/KoDocument.cpp

http://commits.kde.org/calligra/f12c54f30fd8dfcbd0252ed8f116d095af986129
Comment 10 Halla Rempt 2014-02-18 18:39:53 UTC
Git commit 1ea250f407e47ff3c207ed668960e2258b64f303 by Boudewijn Rempt.
Committed on 18/02/2014 at 10:42.
Pushed by rempt into branch 'calligra/2.8'.

M  +1    -0    libs/main/KoDocument.cpp

http://commits.kde.org/calligra/1ea250f407e47ff3c207ed668960e2258b64f303
Comment 11 Halla Rempt 2014-02-19 09:27:26 UTC
Git commit 6502a014d692748954016c48025a72338b14b042 by Boudewijn Rempt.
Committed on 18/02/2014 at 10:42.
Pushed by rempt into branch 'master'.

This was easier than I initially thought

M  +1    -0    libs/main/KoMainWindow.cpp

http://commits.kde.org/calligra/6502a014d692748954016c48025a72338b14b042