Bug 330368

Summary:	JJ: Confirmation dialogs: set input focus on confirmation button instead of cancel
Product:	[Applications] kdevelop	Reporter:	Gregor Mi <codestruct>
Component:	general	Assignee:	kdevelop-bugs-null
Status:	RESOLVED FIXED
Severity:	task	CC:	shubham.chaudhary
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	4.6.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kdevplatform/c64f7f402501133d4ae114f723a38f7463a6cbec	Version Fixed/Implemented In:	1.6.1
Sentry Crash Report:

Description Gregor Mi 2014-01-24 17:24:56 UTC

When searching for files (Ctrl+Alt+F) and there are unsaved files there is a confirmation dialog that asks to save these files. The default action (Enter) is Cancel.

In http://techbase.kde.org/Projects/Usability/HIG/Dialogs there is written about confirmation dialogs:

"Set input focus on confirmation button by default. But set focus on disruptive button (Cancel, Don't apply or the like) if the dialog comprises of critical confirmation. "

The dialog contains no critical information (just a question whether to save or not). Therefore the default button should be "Save selected".

(There are some other confirmation dialogs in kdevelop that could be changed that way)

Comment 1 Shubham Chaudhary 2014-02-27 20:02:32 UTC

Proposed a patch here: https://git.reviewboard.kde.org/r/116457/

Comment 2 Shubham Chaudhary 2014-02-28 14:58:47 UTC

Git commit c64f7f402501133d4ae114f723a38f7463a6cbec by Shubham Chaudhary.
Committed on 28/02/2014 at 14:52.
Pushed by chaudhary into branch '1.6'.

Set default button to 'Save Selected' instead of 'Cancel'
REVIEW: 116457
FIXED-IN: 1.6.1

M  +2    -2    shell/savedialog.cpp

http://commits.kde.org/kdevplatform/c64f7f402501133d4ae114f723a38f7463a6cbec