Bug 330251

Summary: Change the way how paintops are named when the brush already exists.
Product: [Applications] krita Reporter: wolthera <griffinvalley>
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: halla
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: https://commits.kde.org/krita/9f36f1636775c079d1d01a7529ee5dcb23047c14 Version Fixed/Implemented In:
Sentry Crash Report:

Description wolthera 2014-01-21 15:02:20 UTC 
Right now:

*Have a paintop preset. Let's assume it's called 'Brush'
*Change the settings a little and save it again.
*Now in the backend, a new paintop is created 'Brush*gibberish*.kpp', paintop 'Brush.kpp' is then blacklisted.

The disadvantage of this is that when you create brushes for brush kits is that this method requires you figure out which one is the one you wanted, and then to rename that for cleanness purposes.

Suggested behaviour:
*Have a paintop preset. Let's assume it's called 'Brush'
*Change the settings a little and save it again.
*Now in the backend, a new paintop is created 'Brush*gibberish*.kpp'as a copy of paintop 'Brush.kpp'
*paintop 'Brush.kpp' THEN takes the new settings.
* 'Brush*gibberish*.kpp' is  then blacklisted.

Reproducible: Always
Comment 1 Halla Rempt 2016-01-24 11:25:59 UTC 
WISHGROUP: Stretchgoal

Blacklisting/resource management project
Comment 2 wolthera 2017-06-27 12:52:23 UTC 
Git commit 9f36f1636775c079d1d01a7529ee5dcb23047c14 by Wolthera van Hövell tot Westerflier.
Committed on 27/06/2017 at 12:44.
Pushed by woltherav into branch 'master'.

Change the way how paintops are saved.

This does two things:

1. When overwriting a paintop, the unnamed file is the last file, and the new file is a backup of the old file.
2. The backup are named name-date-time.kpp, with the ISO standard for timestampes: big to small.

This makes it easier to manage brush creation, because it removes the need to rename the last file before adding it to a bundle. It also makes managing backups easier, as you do not need to remove the file from the blacklist, only removing the timestap. Finally, timestamps are easier to read.

CCMAIL: kimageshop@kde.org
Differential Revision: https://phabricator.kde.org/D6314
Reviewed by rempt, scottyp, dmitryK, timotheegiet and wysteria[m] on IRC, thanks for testing!

M  +43   -21   libs/ui/kis_paintop_box.cc

https://commits.kde.org/krita/9f36f1636775c079d1d01a7529ee5dcb23047c14