Summary: | Knotify notifications playing twice or even three times on a row | ||
---|---|---|---|
Product: | [Frameworks and Libraries] phonon-backend-vlc | Reporter: | Leszek Lesner <leszek.lesner> |
Component: | general | Assignee: | Harald Sitter <sitter> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bcooksley, fabo, jb, martin.sandsmark, myriam |
Priority: | NOR | ||
Version: | 0.7.1 | ||
Target Milestone: | 0.8 | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/phonon-vlc/170e55291d18f82612a4f429e4a75ee91c30696e | Version Fixed In: | 0.7.2 |
Description
Leszek Lesner
2014-01-19 11:59:11 UTC
Just an additional thing. phonon-backend-vlc is compiled against libvlc 2.1.x Another addition. Tested that on openSUSE aswell as Debian and Ubuntu all with the same result. Git commit 170e55291d18f82612a4f429e4a75ee91c30696e by Harald Sitter. Committed on 20/01/2014 at 08:46. Pushed by sitter into branch '0.7'. Prevent implicit play calls when having queued an invalid source Some applications (knotify4) queue an intentionally bogus source as last source to ensure that we terminate playback. This had the opposite effect since we un-broke queuing as now we'd do a bogus call for play() after not having changed the source. This was causing a chance (somewhat timing dependent) to get duplicated sounds at the end of playback. moveToNextSource now checks whether m_nextSource actually is valid and only if it calls play(). (in the long run it may be worthwhile to consider having setSource return a bool, to only call play() iff setSource actually was able to do stuff) FIXED-IN: 0.7.2 M +9 -1 src/mediaobject.cpp http://commits.kde.org/phonon-vlc/170e55291d18f82612a4f429e4a75ee91c30696e |