Bug 330137

Summary:	Eyedropping on alpha locks brush
Product:	[Applications] krita	Reporter:	jay <jjm.artist>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	dimula73, halla
Priority:	NOR
Version:	2.8 Pre-Alpha
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/6e6941316dea0f5ba344e0998540b8ea4b4de69f	Version Fixed In:
Sentry Crash Report:

Description jay 2014-01-18 21:49:37 UTC

Just a weird thing that happens- when accidentally eyedropping on a transparent part the brush doesn't paint anything (which kind of makes sense) but when toggling to eraser mode the eraser doesn't do anything either. Perhaps expected behavior would be to keep previous brush settings when clicking on a 100% transparent area, or at least allowing the eraser to work. Thanks

 -j

Comment 1 Dmitry Kazakov 2014-01-27 12:36:14 UTC

I guess it should be renamed into something like "Disallow painting with totally transparent brush" :)

Comment 2 Halla Rempt 2014-01-28 10:08:59 UTC

I like not doing anything when color picking a transparent color better.

Comment 3 Halla Rempt 2014-02-18 10:36:42 UTC

Git commit 656e6a0123df961bc36aaf32270eaa893d482ac8 by Boudewijn Rempt.
Committed on 18/02/2014 at 10:35.
Pushed by rempt into branch 'calligra/2.8'.

The opacity of the current fg/bg color is handled by the opacity slider,
not by the current fg/bg color. I checked what photoshop does, and that
also doesn't pick the alpha when picking a color.

M  +1    -0    krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc
M  +3    -3    krita/ui/tool/kis_tool.cc
M  +2    -0    krita/ui/tool/kis_tool_utils.cpp

http://commits.kde.org/calligra/656e6a0123df961bc36aaf32270eaa893d482ac8

Comment 4 Halla Rempt 2014-02-18 10:56:54 UTC

Git commit 6e6941316dea0f5ba344e0998540b8ea4b4de69f by Boudewijn Rempt.
Committed on 18/02/2014 at 10:35.
Pushed by rempt into branch 'master'.

The opacity of the current fg/bg color is handled by the opacity slider,
not by the current fg/bg color. I checked what photoshop does, and that
also doesn't pick the alpha when picking a color.

M  +1    -0    krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc
M  +3    -3    krita/ui/tool/kis_tool.cc
M  +2    -0    krita/ui/tool/kis_tool_utils.cpp

http://commits.kde.org/calligra/6e6941316dea0f5ba344e0998540b8ea4b4de69f

Comment 5 jay 2014-02-18 21:56:58 UTC

The issue comes up only when picking a completely transparent section (by accident of course). Gimp actually makes the color black when picking the 100% transparent area, which maybe makes sense when dealing with alpha channels?

Comment 6 Halla Rempt 2014-02-18 22:26:56 UTC

Yes, the same now happens in krita. Still need to make new Windows packages...