Bug 329846

Summary:	Filters processing not limited by selected area
Product:	[Applications] krita	Reporter:	filarius
Component:	Filters	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR	Keywords:	release_blocker
Version:	2.8 Beta
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	http://commits.kde.org/calligra/2d404d0e6c1856a3c5d502868fdef3e8f0a0f562	Version Fixed In:
Sentry Crash Report:

Description filarius 2014-01-11 12:47:42 UTC

I found filters do not process pixels at only selected regions. 
Filters go through image (layer) fully, but render changes only at selected region.


Reproducible: Always

Steps to Reproduce:
1. Open big image,  about 2000*3000 or more pixels
2. Open Filter menu and choose any "heavy" filter, Blur with 20px radius as example.
3. Check time spended to apply filter.
4. Now Select small region 
5. Apply Filter again and check time.
Actual Results:  
Processing time looks same

Expected Results:  
Small region - few pixels, and must be processed pretty fast.

Comment 1 Dmitry Kazakov 2014-01-29 09:25:22 UTC

Git commit c5d5be1993066b2a501cd7509b9119c8f6dc6010 by Dmitry Kazakov.
Committed on 29/01/2014 at 09:25.
Pushed by dkazakov into branch 'master'.

Limit filter application rect by the deveice bounds and selection

M  +10   -0    krita/ui/tool/strokes/kis_filter_stroke_strategy.cpp

http://commits.kde.org/calligra/c5d5be1993066b2a501cd7509b9119c8f6dc6010

Comment 2 Dmitry Kazakov 2014-01-29 09:26:10 UTC

Git commit 2d404d0e6c1856a3c5d502868fdef3e8f0a0f562 by Dmitry Kazakov.
Committed on 29/01/2014 at 09:25.
Pushed by dkazakov into branch 'calligra/2.8'.

Limit filter application rect by the deveice bounds and selection

M  +10   -0    krita/ui/tool/strokes/kis_filter_stroke_strategy.cpp

http://commits.kde.org/calligra/2d404d0e6c1856a3c5d502868fdef3e8f0a0f562

Comment 3 Dmitry Kazakov 2020-06-13 09:43:55 UTC

Git commit 0fc93bea34b79171b7427e442f342d36dc521426 by Dmitry Kazakov.
Committed on 13/06/2020 at 09:42.
Pushed by dkazakov into branch 'krita/4.3'.

Fix applying invert filter on transparency masks

We should care about KisFilter::needsTransparentPixels() when
auto-cropping processing area.
Related: bug 422805

M  +3    -0    libs/ui/tool/strokes/kis_filter_stroke_strategy.cpp

https://invent.kde.org/graphics/krita/commit/0fc93bea34b79171b7427e442f342d36dc521426

Comment 4 Dmitry Kazakov 2020-06-13 09:44:19 UTC

Git commit 0c68de311da58565ef93ebe2baca24286900e025 by Dmitry Kazakov.
Committed on 13/06/2020 at 09:44.
Pushed by dkazakov into branch 'master'.

Fix applying invert filter on transparency masks

We should care about KisFilter::needsTransparentPixels() when
auto-cropping processing area.
Related: bug 422805

M  +3    -0    libs/ui/tool/strokes/kis_filter_stroke_strategy.cpp

https://invent.kde.org/graphics/krita/commit/0c68de311da58565ef93ebe2baca24286900e025