| Summary: | Crash on undo after source code import | ||
|---|---|---|---|
| Product: | [Applications] umbrello | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | okellogg |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Ralf Habacker
2014-01-06 11:44:30 UTC
Further digging into this problem shows, that at least in CmdSetStereotype and CmdSetVisible the stored uml object pointer isn't valid, which results into the crash. (In reply to comment #0) > [...] > -- Information about the crash: > - What I was doing when the application crashed: > I imported [...] source code. > The import creates many undo entries [...] Good point. IMHO undo/redo should be globally disabled during an import. Git commit 1281519196b65fd226b8812972cf6df8e9acd4be by Ralf Habacker. Committed on 12/01/2014 at 14:03. Pushed by habacker into branch 'master'. Made 'Enable/Disable Undo' setting real working. M +2 -2 umbrello/listpopupmenu.cpp M +87 -44 umbrello/uml.cpp M +10 -4 umbrello/uml.h M +2 -2 umbrello/umldoc.cpp http://commits.kde.org/umbrello/1281519196b65fd226b8812972cf6df8e9acd4be Git commit e575ade17fe5e3dd10f964b86bf9f9a2266224c5 by Ralf Habacker. Committed on 12/01/2014 at 14:03. Pushed by habacker into branch 'KDE/4.12'. Made 'Enable/Disable Undo' setting real working. (cherry picked from commit 1281519196b65fd226b8812972cf6df8e9acd4be) M +2 -2 umbrello/listpopupmenu.cpp M +87 -44 umbrello/uml.cpp M +10 -4 umbrello/uml.h M +2 -2 umbrello/umldoc.cpp http://commits.kde.org/umbrello/e575ade17fe5e3dd10f964b86bf9f9a2266224c5 Git commit 1714e06ff951c301fbc8e1eecf8b63c167836e8b by Ralf Habacker. Committed on 12/01/2014 at 14:47. Pushed by habacker into branch 'KDE/4.12'. Disable undo while code importing to not pollute the undo stack. (cherry picked from commit fd26bdd22cff46d765300f6e5dec005a240e5405) M +9 -0 umbrello/codeimpwizard/codeimpstatuspage.cpp M +1 -0 umbrello/codeimpwizard/codeimpstatuspage.h http://commits.kde.org/umbrello/1714e06ff951c301fbc8e1eecf8b63c167836e8b Git commit 732d15083de5a2d92e18e5c234efc706dab7d8a9 by Ralf Habacker. Committed on 12/01/2014 at 14:03. Pushed by habacker into branch 'KDE/4.11'. Made 'Enable/Disable Undo' setting real working. (cherry picked from commit 1281519196b65fd226b8812972cf6df8e9acd4be) Conflicts: umbrello/listpopupmenu.cpp umbrello/uml.cpp M +2 -2 umbrello/listpopupmenu.cpp M +87 -44 umbrello/uml.cpp M +10 -4 umbrello/uml.h M +2 -2 umbrello/umldoc.cpp http://commits.kde.org/umbrello/732d15083de5a2d92e18e5c234efc706dab7d8a9 Git commit 4df83c1bd7ce868e0d3f76aed793b8c1851f696e by Ralf Habacker. Committed on 12/01/2014 at 14:47. Pushed by habacker into branch 'KDE/4.11'. Disable undo while code importing to not pollute the undo stack. (cherry picked from commit fd26bdd22cff46d765300f6e5dec005a240e5405) M +9 -0 umbrello/codeimpwizard/codeimpstatuspage.cpp M +1 -0 umbrello/codeimpwizard/codeimpstatuspage.h http://commits.kde.org/umbrello/4df83c1bd7ce868e0d3f76aed793b8c1851f696e Git commit fd26bdd22cff46d765300f6e5dec005a240e5405 by Ralf Habacker. Committed on 12/01/2014 at 14:47. Pushed by habacker into branch 'master'. Disable undo while code importing to not pollute the undo stack. The drawback is, that not all widgets could be undo'ed and may confuse users. May be better to merge one import into one undo entry. M +9 -0 umbrello/codeimpwizard/codeimpstatuspage.cpp M +1 -0 umbrello/codeimpwizard/codeimpstatuspage.h http://commits.kde.org/umbrello/fd26bdd22cff46d765300f6e5dec005a240e5405 Crash will not occur by design |