Bug 329525

Summary: Multiple bogus "Lunar New Year's Eve" holidays for HK
Product: [Applications] kdepimlibs Reporter: aditsu <aditsu>
Component: kholidaysAssignee: John Layt <jlayt>
Status: RESOLVED FIXED    
Severity: normal CC: kdepim-bugs
Priority: NOR    
Version: 4.10   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In: 4.14
Sentry Crash Report:

Description aditsu 2014-01-02 11:49:40 UTC 
My calendar is showing 4 (FOUR!) "Lunar New Year's Eve Holiday (Hong Kong SAR(China))" items: on 24 Jan, 30 Jan, 30 Jan and 15 Feb 2014 (yes, two on the same day). According to http://www.gov.hk/en/about/abouthk/holiday/ , none of them is an actual holiday.
It's also showing two "Lunar New Year (Hong Kong SAR(China))" items on 31 Jan, 1 Feb and 2 Feb (total 6) when looking at Jan, but only one on 2 Feb when looking at Feb. 2 Feb is not a Lunar New Year holiday because it's Sunday; 3 Feb should be marked instead.


Reproducible: Always

Steps to Reproduce:
1. Enable holidays for Hong Kong (British English - Information)
2. Open the calendar and check Jan and Feb 2014
3. Facepalm
Comment 1 John Layt 2014-06-20 20:32:22 UTC 
Fixed in 4.14.  A number of the Lunar New Year events were missing their specific year and so were being calculated for every year instead.  Thanks!
Comment 2 John Layt 2014-06-20 22:33:52 UTC 
Git commit 29255466e1435f12875601552e4c77ceb075f87f by John Layt.
Committed on 20/06/2014 at 20:30.
Pushed by jlayt into branch 'master'.

Fix Hong Kong holiday file mistakes

Some lunar holiday dates were missing the correct year so we calculating
for all years.

M  +2    -2    kholidays/holidays/plan2/holiday_hk_en-gb
M  +3    -3    kholidays/holidays/plan2/holiday_hk_zh-cn

http://commits.kde.org/kdepimlibs/29255466e1435f12875601552e4c77ceb075f87f