| Summary: | Layout generator does not support multiple widgets of same object | ||
|---|---|---|---|
| Product: | [Applications] umbrello | Reporter: | Joris Steyn <kde> |
| Component: | general | Assignee: | Ralf Habacker <ralf.habacker> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ralf.habacker |
| Priority: | NOR | ||
| Version: | Git | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/umbrello/a4aabd5b70158c405b0e1472d1a4073edab2309e | Version Fixed In: | 4.13.0 |
| Sentry Crash Report: | |||
|
Description
Joris Steyn
2014-01-01 13:45:24 UTC
A (positive) side effect of the the copy and paste refactoring is that it is now possible to copy and paste multiple widgets of the same class into a class diagram. The layout (and dot-) generator use the widget id() to distinct widgets on the diagram, which do not support this case. They need to use the newly implemented "localID" design. The id is currently fetched through UMLWidget::id() and AssociationWidget::widgetIDForRole(). The first one could be easily refactored, while the latter contains a more complicated implementation going over more call levels. May be the best to add an AssociationWidget::widgetLocalIDForRole() for this purpose. Git commit 0cafa22e2cd2787d45957b08ac0e7333253ba8de by Ralf Habacker. Committed on 27/02/2014 at 08:32. Pushed by habacker into branch 'master'. Let layout generator handle multiple widgets of a single class. M +3 -3 umbrello/dotgenerator.cpp M +4 -4 umbrello/layoutgenerator.h M +19 -0 umbrello/widgets/associationwidget.cpp M +1 -0 umbrello/widgets/associationwidget.h http://commits.kde.org/umbrello/0cafa22e2cd2787d45957b08ac0e7333253ba8de Git commit a4aabd5b70158c405b0e1472d1a4073edab2309e by Ralf Habacker. Committed on 27/02/2014 at 08:32. Pushed by habacker into branch 'KDE/4.13'. Let layout generator handle multiple widgets of a single class. (cherry picked from commit 0cafa22e2cd2787d45957b08ac0e7333253ba8de) M +3 -3 umbrello/dotgenerator.cpp M +4 -4 umbrello/layoutgenerator.h M +19 -0 umbrello/widgets/associationwidget.cpp M +1 -0 umbrello/widgets/associationwidget.h http://commits.kde.org/umbrello/a4aabd5b70158c405b0e1472d1a4073edab2309e Git commit 45d7fb6301b2f6f4b2cc595dbd85e8b6f415d43b by Ralf Habacker. Committed on 27/02/2014 at 08:32. Pushed by habacker into branch 'KDE/4.14'. Let layout generator handle multiple widgets of a single class. M +324 -0 umbrello/layoutgenerator.h http://commits.kde.org/umbrello/45d7fb6301b2f6f4b2cc595dbd85e8b6f415d43b Git commit 7d214c1bdd14332bcac65fe9b8b325674c60dbae by Ralf Habacker. Committed on 27/02/2014 at 08:32. Pushed by habacker into branch 'master'. Let layout generator handle multiple widgets of a single class. M +324 -0 umbrello/layoutgenerator.h http://commits.kde.org/umbrello/7d214c1bdd14332bcac65fe9b8b325674c60dbae Git commit ac1d7e5182e91b4c398238204b7388de3fd2b5a2 by Ralf Habacker. Committed on 27/02/2014 at 08:32. Pushed by habacker into branch 'work/xmi2pot'. Let layout generator handle multiple widgets of a single class. M +324 -0 umbrello/layoutgenerator.h http://commits.kde.org/umbrello/ac1d7e5182e91b4c398238204b7388de3fd2b5a2 Git commit 0398cc1ac5b31e33edffa72efd19429b388f4a84 by Ralf Habacker. Committed on 27/02/2014 at 08:32. Pushed by habacker into branch 'master'. Let layout generator handle multiple widgets of a single class. M +324 -0 umbrello/layoutgenerator.h http://commits.kde.org/umbrello/0398cc1ac5b31e33edffa72efd19429b388f4a84 |