Bug 329324

Summary: Bar graph: allow maximum limit > 100
Product: [Unmaintained] ksysguard Reporter: wilhelmwiens
Component: ksysguardAssignee: KSysGuard Developers <ksysguard-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: knights_of_ni, richard.llom
Priority: NOR    
Version First Reported In: 4.11.3   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/ksysguard/commit/8a64cd93e939063e1e592772a889b904222b974c Version Fixed/Implemented In:
Sentry Crash Report:

Description wilhelmwiens 2013-12-28 16:23:40 UTC 
In the bar settings. Tab 'range'.
The maximum value limited to 100.
But it is possible to set the minimum limit to 10000.

Reproducible: Always

Steps to Reproduce:
1. open ksysguard
2. add an bar(noy bar grhap)
3. open settings
4. try to set the maximum limit over 100
Actual Results:  
you can't set it over 100

Expected Results:  
it shut be possible to set it up to 10000

my patch:

diff --git a/ksysguard/gui/SensorDisplayLib/DancingBarsSettings.cpp b/ksysguard/gui/SensorDisplayLib/DancingBarsSettings.cpp
index 1cf97f88..3656d53 100644
--- a/ksysguard/gui/SensorDisplayLib/DancingBarsSettings.cpp
+++ b/ksysguard/gui/SensorDisplayLib/DancingBarsSettings.cpp
@@ -85,7 +85,7 @@ DancingBarsSettings::DancingBarsSettings( QWidget* parent, const char* name )
   boxLayout->addWidget( label, 0, 3 );
 
   mMaxValue = new QDoubleSpinBox( groupBox);
-  mMaxValue->setRange(0, 100);
+  mMaxValue->setRange(0, 10000);
   mMaxValue->setSingleStep(0.5);
   mMaxValue->setValue(100);
   mMaxValue->setDecimals(2);
Comment 1 Hadrien G. 2019-02-20 10:11:36 UTC 
In general, this bug makes bar graphs unusable for quantities which are not percentages, such as I/O rates or RAM usage.
Comment 2 Bug Janitor Service 2020-07-01 09:02:44 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/ksysguard/-/merge_requests/23
Comment 3 groot 2020-07-01 09:22:37 UTC 
Git commit 8a64cd93e939063e1e592772a889b904222b974c by Adriaan de Groot.
Committed on 30/06/2020 at 14:13.
Pushed by ahiemstra into branch 'master'.

Give max the same range as min (0..10000) spinner.

M  +1    -1    gui/SensorDisplayLib/DancingBarsSettings.cpp

https://invent.kde.org/plasma/ksysguard/commit/8a64cd93e939063e1e592772a889b904222b974c