| Summary: | Brush stroke does not paint anything if it follows Undo very quickly. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73 |
| Priority: | NOR | ||
| Version: | 2.9 Beta | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/cef9ba1d309a2025d5f017ae692ca7e696f30b4b | Version Fixed In: | |
|
Description
Tyson Tan
2013-12-24 12:28:49 UTC
Hi, Tyson! Could you tell the size of the image, color depth and the size of the image? The problem is I cannot reproduce the exact bug you are describing. That is the stroke after 'Z' always starts painting for me. But I have a bit different 'issue': if you press 'Z' too fast after the stroke (when it is not finished in the background yet), then the Undo will not happen. Probably, that is the problem you are describing? Git commit 51a83b3f68d8eec465e1b750c0b3ab2e8ef3cc97 by Dmitry Kazakov. Committed on 25/12/2013 at 14:23. Pushed by dkazakov into branch 'master'. Allow painting when no shortcuts have passed to current combination of keys This patch does two things: 1) Changes the formula of the priority in the way that the shortcuts with left mouse button would have higher priority than ones with middle and right one 2) Add a tag to KisAbstractInputAction::canIgnoreModifiers(), which shows that the action can be run with any particular modifier (the default action). M +5 -0 krita/ui/input/kis_abstract_input_action.cpp M +7 -0 krita/ui/input/kis_abstract_input_action.h M +1 -1 krita/ui/input/kis_input_manager.cpp M +0 -7 krita/ui/input/kis_shortcut_matcher.cpp M +0 -1 krita/ui/input/kis_shortcut_matcher.h M +11 -3 krita/ui/input/kis_stroke_shortcut.cpp M +6 -1 krita/ui/input/kis_tool_invocation_action.cpp M +1 -0 krita/ui/input/kis_tool_invocation_action.h M +0 -3 krita/ui/tests/kis_input_manager_test.cpp http://commits.kde.org/calligra/51a83b3f68d8eec465e1b750c0b3ab2e8ef3cc97 Hi Dmitry, what I meant was exactly what I said, my operating sequence was like: 1) Brush stroke 2) Undo 3) Very quick new brush stroke 4) Operation in 3) doe not paint anything I could reproduce this bug on any resolution and color depth before commit 51a83b3f68d8eec465e1b750c0b3ab2e8ef3cc97. Even though you said could not reproduce my description, with this new commit, I actually can't reproduce this bug any more. So thank you very much! HOWEVER, AFTER the same commit, I actually encountered the exact same problem you described in comment1: 1) Brush stroke 2) Very quick Undo 3) Undo in 2) does not undo I think this is because when I clicked Undo very quickly after a brush stroke, the brush stroke either had not yet finished painting on the canvas, or my hand had not finished drawing the last bit, as my thought was faster than my hand. My suggestion is that in addition to you new commit, you might want to add something like this: Whenever a user use Undo, the current operation will be interrupted immediately and the unfinished part on the canvas will be reverted as well. Currently, it seems to me that an brush stroke must be completed before an Undo command can be accepted by Krita. Git commit cef9ba1d309a2025d5f017ae692ca7e696f30b4b by Dmitry Kazakov. Committed on 25/12/2013 at 14:23. Pushed by dkazakov into branch 'calligra/2.8'. Allow painting when no shortcuts have passed to current combination of keys This patch does two things: 1) Changes the formula of the priority in the way that the shortcuts with left mouse button would have higher priority than ones with middle and right one 2) Add a tag to KisAbstractInputAction::canIgnoreModifiers(), which shows that the action can be run with any particular modifier (the default action). M +5 -0 krita/ui/input/kis_abstract_input_action.cpp M +7 -0 krita/ui/input/kis_abstract_input_action.h M +1 -1 krita/ui/input/kis_input_manager.cpp M +0 -7 krita/ui/input/kis_shortcut_matcher.cpp M +0 -1 krita/ui/input/kis_shortcut_matcher.h M +11 -3 krita/ui/input/kis_stroke_shortcut.cpp M +6 -1 krita/ui/input/kis_tool_invocation_action.cpp M +1 -0 krita/ui/input/kis_tool_invocation_action.h M +0 -3 krita/ui/tests/kis_input_manager_test.cpp http://commits.kde.org/calligra/cef9ba1d309a2025d5f017ae692ca7e696f30b4b |