| Summary: | crash when adding new player in game setup screen | ||
|---|---|---|---|
| Product: | [Applications] konquest | Reporter: | Alexander Schuch <aschuch247> |
| Component: | general | Assignee: | Alexander Schuch <aschuch247> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | kde-games-bugs |
| Priority: | NOR | ||
| Version: | 2.1 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/konquest/81b303225fb9149aeadb63878d0ebd0501e5a25e | Version Fixed In: | 4.11.5 |
| Sentry Crash Report: | |||
|
Description
Alexander Schuch
2013-12-23 16:52:19 UTC
Git commit 238c8f3f12c84107be9095e63b135e8c94786f00 by Alexander Schuch. Committed on 24/12/2013 at 03:28. Pushed by aschuch into branch 'KDE/4.11'. Properly check for a valid selection in minimap. Changing the dimensions of the map in game setup dialogue recreates the game board. The sector selection is kept. However, the selection might become invalid if the game board shrinks and the selection is not on the board anymore. Adding a new player to the game will then result in checking a sector outside the game board (NULL is returned), so that a method is invoked on a NULL pointer, leading to a crash - see NewGameDlg::slotNewOwner(). This is implemented in Konquest 2.1. FIXED-IN: 4.11.5 M +1 -1 minimapview.h http://commits.kde.org/konquest/238c8f3f12c84107be9095e63b135e8c94786f00 Git commit 1a05c5dec81aab9b8bba5fd715c8dd08b85a37c3 by Alexander Schuch. Committed on 24/12/2013 at 03:28. Pushed by aschuch into branch 'KDE/4.12'. Properly check for a valid selection in minimap. Changing the dimensions of the map in game setup dialogue recreates the game board. The sector selection is kept. However, the selection might become invalid if the game board shrinks and the selection is not on the board anymore. Adding a new player to the game will then result in checking a sector outside the game board (NULL is returned), so that a method is invoked on a NULL pointer, leading to a crash - see NewGameDlg::slotNewOwner(). This is implemented in Konquest 2.1. FIXED-IN: 4.11.5 (cherry picked from commit 238c8f3f12c84107be9095e63b135e8c94786f00) M +1 -1 minimapview.h http://commits.kde.org/konquest/1a05c5dec81aab9b8bba5fd715c8dd08b85a37c3 Git commit 81b303225fb9149aeadb63878d0ebd0501e5a25e by Alexander Schuch. Committed on 24/12/2013 at 03:28. Pushed by aschuch into branch 'master'. Properly check for a valid selection in minimap. Changing the dimensions of the map in game setup dialogue recreates the game board. The sector selection is kept. However, the selection might become invalid if the game board shrinks and the selection is not on the board anymore. Adding a new player to the game will then result in checking a sector outside the game board (NULL is returned), so that a method is invoked on a NULL pointer, leading to a crash - see NewGameDlg::slotNewOwner(). This is implemented in Konquest 2.1. FIXED-IN: 4.11.5 (cherry picked from commit 238c8f3f12c84107be9095e63b135e8c94786f00) M +1 -1 minimapview.h http://commits.kde.org/konquest/81b303225fb9149aeadb63878d0ebd0501e5a25e |