Summary: | Photo search for contact email should be case-insensitive | ||
---|---|---|---|
Product: | [Applications] kmail2 | Reporter: | Sven <Fd3querm> |
Component: | UI | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | Fd3querm, montel |
Priority: | NOR | ||
Version: | 4.11.3 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdepim/531f1fdf306aa179b6ee8bf5bd9659f47d1bc07b | Version Fixed In: | 4.12.1 |
Description
Sven
2013-12-13 22:51:31 UTC
Might be the reason for https://bugs.kde.org/show_bug.cgi?id=316029 as well. StartsWithMatch, ///< The result must start with the pattern (case insensitive). ContainsMatch, ///< The result must contain the pattern (case insensitive). no we must use ContainsMatch startWithMatch will return Joesdfsdfsfsdf, Joe, joeqsss etc. but it's right ContainsMatch not perfect too... It will return not correct value... But by default we store in akonadi emails has lowcase. Not sure that we must change search attribute we will break a lot. Okay, StartsWithMatch was reasonable for me. If emails are stored lower case, the email being searched can be converted to lower case in advance, or? searchJob->setQuery( Akonadi::ContactSearchJob::Email, emailAddress.toLower() ) Thanks for taking care of the bug! Git commit 531f1fdf306aa179b6ee8bf5bd9659f47d1bc07b by Montel Laurent. Committed on 22/12/2013 at 06:25. Pushed by mlaurent into branch 'KDE/4.12'. Fix Bug 328777 - Photo search for contact email should be case-insensitive FIXED-IN: 4.12.1 M +1 -1 libkdepim/job/addcontactjob.cpp M +1 -1 libkdepim/job/addemailaddressjob.cpp M +1 -1 libkdepim/job/addemaildisplayjob.cpp M +1 -1 libkdepim/job/openemailaddressjob.cpp M +4 -4 mailcommon/search/searchpattern.cpp M +1 -1 messagecomposer/recipient/distributionlistdialog.cpp M +1 -1 messageviewer/header/contactdisplaymessagememento.cpp http://commits.kde.org/kdepim/531f1fdf306aa179b6ee8bf5bd9659f47d1bc07b |