Bug 328717

Summary:	Relative folder icon support
Product:	[Unmaintained] kfile	Reporter:	tesfabpel
Component:	kpropertiesdialog	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	wishlist	CC:	frank78ac, nate
Priority:	NOR
Version First Reported In:	4.11.3
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description tesfabpel 2013-12-12 11:39:13 UTC

If I set an icon to a folder (via the properties window) it creates a .directory file with the absolute path of the icon...

Anyway, it should be possible to set the Icon key to a relative path, like:
Icon=./dir-icon.png

In Konqueror it works though (thanks to the solution of bug 73463)

The use of an absolute path becomes a problem when you move or rename the folder or you place the folder in an external drive (because for example, Fedora mounts the partition in /run/media/... and Debian in /media/...)

Maybe the path can be set automatically to relative if the icon is inside the folder?

Reproducible: Always

Steps to Reproduce:
1. Change a folder's icon to one that is inside the folder.
2. Dolphin creates a .directory with an Icon key that has an absolute path of the icon.
3. Change the path to be a relative one.
Actual Results:  
The Icon doesn't get displayed...

Expected Results:  
The Icon should be displayed (like it is in Konqueror)

As I said the properties window could be changed so that if you choose an icon that is under the folder you're editing, Dolphin uses automatically the relative path of the icon...

Comment 1 Frank Reininghaus 2013-12-12 11:51:17 UTC

Thanks for the report. I'm not sure if I really understand what you mean. If I set the path

Icon=./test.png

in the .directory file, then the correct icon is shown in Dolphin. If I understand correctly, you are saying that this only works in Konqueror for you?

About changing the icon in the "Properties" dialog - the dialog is part of kdelibs. We cannot do anything about that inside Dolphin.

I still don't get what exact difference you see between Dolphin and Konqueror. It would be good if you could try to explain it in more detail. Thanks.

Comment 2 tesfabpel 2013-12-13 08:48:31 UTC

Oooook, yesterday it was NOT working... -.- (Why?? xD)

Anyway, I'll change the bug so that the part of automatic relative path remains since I think it's a usability improvement...

Comment 3 Frank Reininghaus 2013-12-13 10:29:44 UTC

Thanks for the update!

As I said, the "Properties" dialog is not a part of Dolphin itself, so I'll reassign this report.

Comment 4 Nate Graham 2018-06-15 02:06:16 UTC

Automatically using relative paths would simply break other use cases. I think people are far more likely to mode their custom-icon-bearing folders to different locations on the same disk than they are to move whole folder structures onto a different disk. Sorry, we won't be able to implement this--though if you come up with a clever patch that doesn't break anything, we'll consider it!