| Summary: | Support for Accelerated Thread Local Storage (TLS) Access optimization on CVM MIPS | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Dr. Zahid Anwar, School of Electrical Engg. & Computer Science, National Univ. of Sciences & Technology, Islamabad, Pakistan <zahid.anwar> |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | CC: | cdleonard, dejanjevtic87, maran.pakkirisamy, mips32r2 |
| Priority: | NOR | ||
| Version First Reported In: | 3.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | Debian stable | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Patch for TLS Issue | ||
|
Description
Dr. Zahid Anwar, School of Electrical Engg. & Computer Science, National Univ. of Sciences & Technology, Islamabad, Pakistan
2013-12-11 15:09:57 UTC
Comment 1
Dr. Zahid Anwar, School of Electrical Engg. & Computer Science, National Univ. of Sciences & Technology, Islamabad, Pakistan
2013-12-11 15:13:17 UTC
Created attachment 84046 [details]
Patch for TLS Issue
****************** PREREQUISITES *****************
----Testing Environment specification:-----
SDK 3.0 with new tool chain
Tool-chain tool-121004
gcc version 4.7
glibc version 2.16
kernel version 3.4.27-rt37-Cavium-Octeon
cpu info Cavium Octeon II V0.1
MotherBoard OCTEON_CN63XX
valgrind 3.10.0 r13752 release 13752
command to checkout: svn co -r 13752 svn://svn.valgrind.org/valgrind/trunk valgrind
****************** Applying patch *****************
copy patch file to valgrind folder and following command should be run to apply patch.
run patch -p2 -i valgrind_tls_10_dec_2013.patch
****************** Files patched *****************
patch file coregrind/m_syswrap/syswrap-mips64-linux.c
AFAIU, this is Cavium specific issue that is present for Cavium Octeon and Octeon Plus, but not for Cavium II, correct? If so, we want to limit any changes to early Cavium variants. So, VG_(get_machine_model) should be extended to recognize separate variants (similar to what mips_features.c in the tests folder already does). Further, can we have a test case that is failing rather than relying on what toolchain would generate? Thanks. Petar, I just realized that the kernel patch to support thread local storage acceleration is not upstream and hence this patch will not make sense beyond the octeon toolchains. Hence I request to ignore this patch and close the bug. (In reply to Maran Pakkirisamy from comment #3) > Petar, > I just realized that the kernel patch to support thread local storage > acceleration is not upstream and hence this patch will not make sense beyond > the octeon toolchains. Hence I request to ignore this patch and close the > bug. I have got no objections. We can close it as won't fix. |