Summary: | Rawtherapee crashes occasionally when using oxygen-gtk | ||
---|---|---|---|
Product: | [Plasma] Oxygen | Reporter: | Torsten Römer <dode> |
Component: | gtk2-engine | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | b7.10110111, bugs, christian_bay, hugo.pereira.da.costa, tim.taylor+bugzilla.bugs.kde.org, web, yyc1992 |
Priority: | NOR | ||
Version: | 4.11.2 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | Backtrace rawtherapee crash |
Description
Torsten Römer
2013-12-06 18:07:42 UTC
I think this stack trace is identical to my stripped out Eclipse stack trace. So hopefully we'll get to the bottom of if. Created attachment 83957 [details]
Backtrace rawtherapee crash
Another backtrace from a crash in rawtherapee possibly related to oxygen-gtk.
Git commit c52b7367d99444ace2743c87364591cb0dd164a7 by Hugo Pereira Da Costa. Committed on 03/01/2014 at 17:47. Pushed by hpereiradacosta into branch '1.4'. properly reset _previous and _current widget, if matching, in case of child destruction, for ToolbarStateData, MenuStateData, MenuBarStateData Related: bug 329112, bug 324438, bug 325196 M +91 -0 src/animations/oxygenmenubarstatedata.cpp M +15 -0 src/animations/oxygenmenubarstatedata.h M +90 -0 src/animations/oxygenmenustatedata.cpp M +15 -0 src/animations/oxygenmenustatedata.h M +13 -0 src/animations/oxygentoolbarstatedata.cpp http://commits.kde.org/oxygen-gtk/c52b7367d99444ace2743c87364591cb0dd164a7 @Torsten Can you try when compiling version 1.4 from source ? I "think" I have fixed the issue, although I did not check extensively (the code change in ToolbarStateData makes sense though in terms on how the old code could indeed crash and the new one should not) Keep me posted Git commit a9fd101716d92623e410099d9b13f31cb3236fe8 by Hugo Pereira Da Costa. Committed on 03/01/2014 at 17:47. Pushed by hpereiradacosta into branch 'gtk3'. properly reset _previous and _current widget, if matching, in case of child destruction, for ToolbarStateData, MenuStateData, MenuBarStateData Related: bug 329112, bug 324438, bug 325196 M +91 -0 src/animations/oxygenmenubarstatedata.cpp M +15 -0 src/animations/oxygenmenubarstatedata.h M +90 -0 src/animations/oxygenmenustatedata.cpp M +15 -0 src/animations/oxygenmenustatedata.h M +13 -0 src/animations/oxygentoolbarstatedata.cpp http://commits.kde.org/oxygen-gtk/a9fd101716d92623e410099d9b13f31cb3236fe8 Git commit bd052fe914c6cf9da70dd4ab931a4b563cb6e742 by Hugo Pereira Da Costa. Committed on 03/01/2014 at 17:47. Pushed by hpereiradacosta into branch 'gtk3-1.2'. properly reset _previous and _current widget, if matching, in case of child destruction, for ToolbarStateData, MenuStateData, MenuBarStateData Related: bug 329112, bug 324438, bug 325196 M +91 -0 src/animations/oxygenmenubarstatedata.cpp M +15 -0 src/animations/oxygenmenubarstatedata.h M +90 -0 src/animations/oxygenmenustatedata.cpp M +15 -0 src/animations/oxygenmenustatedata.h M +13 -0 src/animations/oxygentoolbarstatedata.cpp http://commits.kde.org/oxygen-gtk/bd052fe914c6cf9da70dd4ab931a4b563cb6e742 Very nice. I have built version 1.4 and did some editing in rawtherapee, no crash so far. But I will have to do a lot more editing before I can make a qualified statement - I will try to do so soon and let you know. Cheers! Hi What version of oxygen-gtk will this fix be in? @DrLsony That will be version 1.4.2 scheduled in a week or two. But I'd recommend to test the code from git before that, in case somethingvelse shows up. Hugo @DrLsony That will be version 1.4.2 scheduled in a week or two. But I'd recommend to test the code from git before that, in case somethingvelse shows up. Hugo @Torsten any news ? I really expect the crash not to be (directly) related to multiple display. (although yes, this might trigger it more often. Was an issue with accessing invalid memory, hence the seemingly random occurence). Closing the bug as fixed from now (got positive feedback on other, similar bug reports). Feel free to reopen if crashes reoccur. Thanks for helping getting to the bottom of it. @Hugo I did not get around to use rawtherapee as intensively as I did when those crashes occurred, but there has been no crash since the fix for me as well, also not in Eclipse. Should a (related) crash occur again I will let you know. I BTW mainly use a single display setup. Thanks for fixing this issue! :-) (as for the display setup: sorry, that was for another bug report ;)) @Hugo, I am just wondering if this crash can be related C [libgtk-x11-2.0.so.0+0x2202ea] gtk_tree_view_get_background_area+0x8a I can reproduce it quite reliably when debugging in Eclipse with the oxygen-gtk GTK2-Design. With Raleigh I am unable to reproduce the crash. But my eyes really prefer oxygen-gtk :-) Unfortunately I don't know how to provide a useful backtrace, but I'll try to find out. Torsten I got a backtrace from a core dump. Please let me know what debug packages to install to get more infos if you want! #6 0x00007f2292d3d2ea in IA__gtk_tree_view_get_background_area ( tree_view=0x7f22d0908990, path=0x7f22d197ce00, column=0x7f22d08c5570, rect=0x7f22d6fdabf0) at /build/buildd/gtk+2.0-2.24.23/gtk/gtktreeview.c:13045 __inst = 0x7f22d08c5570 __t = 139787504457888 __r = <optimised out> _g_boolean_var_ = <optimised out> tree = 0x0 node = 0x0 __FUNCTION__ = "IA__gtk_tree_view_get_background_area" #7 0x00007f229263db58 in Oxygen::Gtk::CellInfo::backgroundRect(_GtkTreeView*) const () from /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so No symbol table info available. #8 0x00007f229262f19d in Oxygen::TreeViewStateData::dirtyRect() () ---Type <return> to continue, or q <return> to quit--- from /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so No symbol table info available. #9 0x00007f229262f320 in Oxygen::TreeViewStateData::delayedUpdate(void*) () from /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so No symbol table info available. #10 0x00007f229262eea6 in Oxygen::TreeViewStateData::updateState(Oxygen::Gtk::CellInfo const&, bool) () from /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so No symbol table info available. #11 0x00007f229260bcd1 in Oxygen::TreeViewStateEngine::get(_GtkWidget*, Oxygen::Gtk::CellInfo const&, Oxygen::StyleOptions const&) () from /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so No symbol table info available. #12 0x00007f22926b43a9 in ?? () from /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so No symbol table info available. #13 0x00007f2292d30a34 in gtk_tree_view_draw_arrow ( tree_view=tree_view@entry=0x7f22d0908990, tree=tree@entry=0x7f22d0eb3470, node=node@entry=0x7f22d1184460, x=x@entry=0, y=y@entry=65) at /build/buildd/gtk+2.0-2.24.23/gtk/gtktreeview.c:9598 area = {x = 0, y = 63, width = 12, height = 19} state = <optimised out> widget = 0x7f22d0908990 x_offset = 0 x2 = 15 vertical_separator = 0 expander_size = <optimised out> ---Type <return> to continue, or q <return> to quit--- expander_style = <optimised out> #14 0x00007f2292d36e0b in do_prelight (tree_view=tree_view@entry=0x7f22d0908990, tree=0x7f22d0eb3470, node=0x7f22d1184460, x=0, y=65) at /build/buildd/gtk+2.0-2.24.23/gtk/gtktreeview.c:3284 No locals. #15 0x00007f2292d3e3a4 in prelight_or_select (tree_view=tree_view@entry=0x7f22d0908990, tree=<optimised out>, node=<optimised out>, x=<optimised out>, y=<optimised out>) at /build/buildd/gtk+2.0-2.24.23/gtk/gtktreeview.c:3334 mode = <optimised out> #16 0x00007f2292d40af5 in gtk_tree_view_enter_notify (widget=0x7f22d0908990, event=0x7f22d1531820) at /build/buildd/gtk+2.0-2.24.23/gtk/gtktreeview.c:5634 tree_view = 0x7f22d0908990 tree = 0x7f22d0eb3470 node = 0x7f22d1184460 new_y = <optimised out> Hi Torsen The backtrace is very useful, I can probably ellaborate on that and submit a patch for you to test. The crash is likely a different one from the one that got "fixed" here. But let us try to fix it here nonetheless. Hi Hugo, Did you have a chance to have a look at the crash? Anything I can help out with? Cheers, Torsten |