| Summary: | oxygen-gtk3 uses strange colors for Label on Fixed and Notebook's tabs for mcc | ||
|---|---|---|---|
| Product: | [Plasma] Oxygen | Reporter: | tv <thierry.vignaud> |
| Component: | gtk3-engine | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | b7.10110111, hugo.pereira.da.costa, web |
| Priority: | NOR | ||
| Version First Reported In: | 1.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Mageia RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
bogus splash screen
bogus notebook on left all-in-one patch mcc using gtk3 (WIP°) its CSS file fix gray text on gray (when cursor is on left labels) with adwaita, it's OK with adwaita, it's OK (black text over white bg) with oxygen-gtk3, bg of the label with the cursor is on is blue |
||
|
Description
tv
2013-12-03 13:32:12 UTC
Created attachment 83897 [details]
bogus splash screen
Created attachment 83898 [details]
bogus notebook on left
@Thierry, likely more issues with css. Did you push the new mcc already so that I can test ? It is very difficult to "guess" the issue without it, sadly. Some of the changes I have locally should fix at least the background issue. Might not be true for the foreground, though. Created attachment 83899 [details]
all-in-one patch
This is an all-in-one patch.
It should superseed the other patches sent on that topic, and actually fix the issues reported in this bug.
Keep me posted,
Hugo
No I've not yet pushed gtk3 mcc. This patch didn't fixed the background Created attachment 83901 [details]
mcc using gtk3 (WIP°)
Created attachment 83902 [details]
its CSS file
Thanks for the includes, Do you have any instructions on how I can actually start it here ? (right now it fails with: undefined value for mandatory argument 'path' encountered at /home/hpereira/gtk/mcc/control-center.txt line 89. (where it is supposed to load the css) Thanks in advance, hugo It should be is actually the RC file, in /usr/share/mcc/themes/default/ ok. Thanks ! now I can run. More later. For the record, I see the same issues with (current) Adwaita here. Can you confirm ? Indeed. I'll see with upstream Thought it looks like a recent change makes the same bug happens for installer: see https://bugs.mageia.org/show_bug.cgi?id=11866 Just copying the older /usr/lib/gtk-3.0/3.0.0/theming-engines/liboxygen-gtk.so in installer image fixed it so it's a regression in one of the two patches you provided yes, I can confirm that with older oxygen-gtk3 the issue is gone. So I'll investigate the difference. Will keep you posted. Investigating a bit: it seems that the background color for the GtkLabels of mcc is set to blue in some of the css files you are using. (if I set them to transparent in my css files explicitly this is not respected, so must be overwritten somewhere in apps specific css) This was explicitly ignored in previous oxygen-gtk3, disregarding css. I removed that along the fix to diskdrake, as it should be. This explain why - the bug was not there before - it is there now - it is also there with adwaita, which does a better job than us at respecting css files. Can you double check on your side ? I would hate re-introduce the explicit "ignore css" that was there before ... From my own investigation, the background set in:
#Logo, #Steps * {
/* base[NORMAL] = { 0.28, 0.38, 0.66 }; */
background-color: #548EE6;
color: #FFFFFF;
}
is the bad guy.
That's the one that gets set as flat background for any gtkLabel in mcc.
welcome to css gtk3 mess
(in theme-galaxy.cxx) I sense a bit of ironics :-) Thanks for debugging it :-) Sorry for the false bug report I now need to fix the CSS for highlighted items which are rendered white on gray... CSS fixed for hover elements too Created attachment 83925 [details]
fix gray text on gray (when cursor is on left labels)
Created attachment 83926 [details]
with adwaita, it's OK
Created attachment 83927 [details]
with adwaita, it's OK (black text over white bg)
Created attachment 83928 [details]
with oxygen-gtk3, bg of the label with the cursor is on is blue
... which I supposed is fine according to Oyxgen-gtk3 guidelines but:
- the black color is not enforced
- the white color is not enforced (when the cursor is over)
=> I may need a way to differentiate Adwaita from Oxygen in CSS in order
to set fg color to black only for Adwaita
So the issue is basically that hover effects are mutually exclusive in terms of foreground color netween adwaita and oxygen. My suggestion would be to reimplement the hover effect in css. For oxygen it will be mostly ignored (no comment). For adwaita however, since it is entirely css based, it should overwrite adwaita. If you implement something similar to oxygen, that would fix the issue ... I can help on that if needed. Note that in fact, implementing you own background color for hovered buttons would probably be honored by both oxygen and adwaita, thus also fixing the issue (must be tried) ... Reopening, then. I really like mcc. Ready to help making it look good Thanks. We could do that indeed. so ... problem fixed. closing |