| Summary: | unexpected crash- eyedrop toggle broken | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | jay <jjm.artist> |
| Component: | General | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | dimula73, griffinvalley |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/753e3d5dc3c18858cc45ac56603cb5e047c86c59 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
jay
2013-12-02 02:08:09 UTC
Hi, jay! Thank you for your report! Indeed this crash happens when one tries to paint on disabled or invisible layer. I will try to fix it as soon as possible. Git commit 8901cf23a0fcb61d1ca42eea3e3e04f1905eafac by Dmitry Kazakov. Committed on 02/12/2013 at 08:17. Pushed by dkazakov into branch 'master'. Disallow the start of prohibited actions Now the tool can choose not to get move/release events for the actions it doesn't want to have. If the tool calls event->ignore() in beginPrimaryAction(), it will not get any further events for this particular action. M +7 -3 krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc M +4 -1 krita/plugins/tools/defaulttools/kis_tool_fill.cc M +10 -0 krita/plugins/tools/defaulttools/kis_tool_gradient.cc M +5 -5 krita/plugins/tools/defaulttools/kis_tool_line.cc M +4 -0 krita/plugins/tools/defaulttools/kis_tool_measure.cc M +9 -3 krita/plugins/tools/defaulttools/kis_tool_move.cc M +0 -3 krita/plugins/tools/defaulttools/kis_tool_multihand.cpp M +5 -1 krita/plugins/tools/selectiontools/kis_tool_select_brush.cc M +6 -6 krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc M +4 -0 krita/plugins/tools/selectiontools/kis_tool_select_outline.cc M +7 -10 krita/plugins/tools/selectiontools/kis_tool_select_similar.cc M +208 -209 krita/plugins/tools/tool_crop/kis_tool_crop.cc M +22 -5 krita/plugins/tools/tool_grid/kis_tool_grid.cc M +11 -1 krita/ui/canvas/kis_tool_proxy.cpp M +6 -1 krita/ui/canvas/kis_tool_proxy.h M +7 -6 krita/ui/input/kis_tool_invocation_action.cpp M +9 -9 krita/ui/tool/kis_tool_freehand.cc M +5 -1 krita/ui/tool/kis_tool_polyline_base.cpp M +6 -1 krita/ui/tool/kis_tool_rectangle_base.cpp http://commits.kde.org/calligra/8901cf23a0fcb61d1ca42eea3e3e04f1905eafac Git commit 753e3d5dc3c18858cc45ac56603cb5e047c86c59 by Dmitry Kazakov. Committed on 02/12/2013 at 08:17. Pushed by dkazakov into branch 'calligra/2.8'. Disallow the start of prohibited actions Now the tool can choose not to get move/release events for the actions it doesn't want to have. If the tool calls event->ignore() in beginPrimaryAction(), it will not get any further events for this particular action. M +7 -3 krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc M +4 -1 krita/plugins/tools/defaulttools/kis_tool_fill.cc M +10 -0 krita/plugins/tools/defaulttools/kis_tool_gradient.cc M +5 -5 krita/plugins/tools/defaulttools/kis_tool_line.cc M +4 -0 krita/plugins/tools/defaulttools/kis_tool_measure.cc M +9 -3 krita/plugins/tools/defaulttools/kis_tool_move.cc M +0 -3 krita/plugins/tools/defaulttools/kis_tool_multihand.cpp M +5 -1 krita/plugins/tools/selectiontools/kis_tool_select_brush.cc M +6 -6 krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc M +4 -0 krita/plugins/tools/selectiontools/kis_tool_select_outline.cc M +7 -10 krita/plugins/tools/selectiontools/kis_tool_select_similar.cc M +208 -209 krita/plugins/tools/tool_crop/kis_tool_crop.cc M +22 -5 krita/plugins/tools/tool_grid/kis_tool_grid.cc M +11 -1 krita/ui/canvas/kis_tool_proxy.cpp M +6 -1 krita/ui/canvas/kis_tool_proxy.h M +7 -6 krita/ui/input/kis_tool_invocation_action.cpp M +9 -9 krita/ui/tool/kis_tool_freehand.cc M +5 -1 krita/ui/tool/kis_tool_polyline_base.cpp M +6 -1 krita/ui/tool/kis_tool_rectangle_base.cpp http://commits.kde.org/calligra/753e3d5dc3c18858cc45ac56603cb5e047c86c59 *** Bug 328429 has been marked as a duplicate of this bug. *** I figure it's best to post in the main bug, so yeah I still have this bug. I do have the latest version of Krita(versioning was set to 2.9 alpha recently, not? It's version 2.9 alpha, so.) and I do have this bug when painting on a locked layer.(As well as the eyedropper bug) (In reply to comment #5) > I figure it's best to post in the main bug, so yeah I still have this bug. > I do have the latest version of Krita(versioning was set to 2.9 alpha > recently, not? It's version 2.9 alpha, so.) and I do have this bug when > painting on a locked layer.(As well as the eyedropper bug) Oh, sorry.. seems like that commit didn't reach the Krita Lime. Ok, I've just requested a new packages build, so the updated packages will be ready in about 6-8 hours. Please update and check when the are ready. It's working now :) (And of course, the eyedropper being bugged was because of the adjustments to the canvas input settings :) ) |