Bug 328258

*** Bug 300721 has been marked as a duplicate of this bug. ***

Created attachment 83990 [details]
New crash information added by DrKonqi

k3b (2.0.80) on KDE Platform 4.11.2 using Qt 4.8.5

- What I was doing when the application crashed:
Inserted CD. Opened K3b. Selected "start ripping". Selected MP3. Application crashed. Retried at least six times. Crashes the same way every time.

-- Backtrace (Reduced):
#6  operator= (o=..., this=0x7ffa0fffec10) at /usr/include/QtCore/qshareddata.h:97
#7  K3b::Msf::Msf (this=0x7ffa0fffec10, m=...) at /usr/src/debug/k3b-2.0.80.git20131118/libk3bdevice/k3bmsf.cpp:83
#8  0x00007ffa3dd04d86 in K3b::operator- (m1=..., m2=...) at /usr/src/debug/k3b-2.0.80.git20131118/libk3bdevice/k3bmsf.cpp:359
#9  0x00007ffa3dcff74c in K3b::Device::Track::length (this=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/libk3bdevice/k3btrack.cpp:95
#10 0x00000000004cdcf9 in K3b::AudioRipJob::trackLength (this=<optimized out>, trackIndex=10) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3baudioripjob.cpp:282

I also get a crash, but I don't need to select Rip to mp3 to reproduce it, I get it for any option (for example, ogg). Same specs as Ralph DeWitt, but unfortunately I cannot generate a useful stack trace, KDE does not do anything when I press the key to install debug symbols.

Have you installed K3b-codecs-debuginfo, k3b-debuginfo and
k3b-debugsource packages yet? That's what I had to do.

On 12/08/2013 04:11 PM, mavroprovato@gmail.com wrote:
> https://bugs.kde.org/show_bug.cgi?id=328258
>
> --- Comment #3 from mavroprovato@gmail.com ---
> I also get a crash, but I don't need to select Rip to mp3 to reproduce it, I
> get it for any option (for example, ogg). Same specs as Ralph DeWitt, but
> unfortunately I cannot generate a useful stack trace, KDE does not do anything
> when I press the key to install debug symbols.
>

On Sunday, December 08, 2013 10:21:16 PM you wrote:
> https://bugs.kde.org/show_bug.cgi?id=328258
> 
> --- Comment #4 from Jon <jon.wesenberg@gmail.com> ---
> Have you installed K3b-codecs-debuginfo, k3b-debuginfo and
> k3b-debugsource packages yet? That's what I had to do.
> 
> On 12/08/2013 04:11 PM, mavroprovato@gmail.com wrote:
> > https://bugs.kde.org/show_bug.cgi?id=328258
> > 
> > --- Comment #3 from mavroprovato@gmail.com ---
> > I also get a crash, but I don't need to select Rip to mp3 to 
reproduce it,
> > I get it for any option (for example, ogg). Same specs as Ralph 
DeWitt,
> > but unfortunately I cannot generate a useful stack trace, KDE does 
not do
> > anything when I press the key to install debug symbols.
Jon:
I did not have all the debug packages installed. I have now downloaded 
and installed all the debug packages and did a build up date. Will test 
and report.

I have added the requested debug packages and updated to the latest build of 2.0.80.git20131118-1.4 on packman. I have tried to rip a cd four more times with no useful debug info coming out of the crash. It just segfaults with no info.

When testing Dr Konqi states debug packages are not installed for k3b. Yast and apper state the packages are installed. Currently I am still unable to generaate useful backtrace. I do not know how to proceed further to help fix the problem.

I had my K3b working perfectly, but, after a mid-November update from openSUSE's packman repository, it started showing this same behavior: whenever I try to rip a CD – doesn't matter which encoding, this happens either with MP3 or Ogg – K3b crashes immediately after the rip procedure begins. Sometimes I can briefly see during a fraction of a second the ripping progress dialog box, but the end is always the same: a segmentation fault.

Created attachment 84142 [details]
New crash information added by DrKonqi

k3b (2.0.80) on KDE Platform 4.11.3 using Qt 4.8.5

- What I was doing when the application crashed:Tried to rip a audio cd to mp3 format. I insereted the cd in drive, selected ripaudio cd with k3b from pop up menu., Edited album cddb, selected save to local cddb (did not see any indication of it saving to local cddb) seleced to rip to mp3(lame), selected a local file to rip too, selected start ripping.

-- Backtrace (Reduced):
#5  operator-> (this=0x0) at /usr/include/QtCore/qshareddata.h:79
#6  K3b::Device::Track::length (this=0x0) at /usr/src/debug/k3b-2.0.80.git20131118/libk3bdevice/k3btrack.cpp:95
#7  0x00000000004cdcf9 in K3b::AudioRipJob::trackLength (this=<optimized out>, trackIndex=10) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3baudioripjob.cpp:282
#8  0x00000000004dda0e in K3b::MassAudioEncodingJob::run (this=0x1d33340) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3bmassaudioencodingjob.cpp:205
#9  0x00007f5124e36c25 in K3b::Thread::run (this=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/libk3b/core/k3bthread.cpp:62

Created attachment 84163 [details]
New crash information added by DrKonqi

k3b (2.0.80) on KDE Platform 4.11.4 using Qt 4.8.5

- What I was doing when the application crashed:

Try to rip a cd-rom audio. The crash occur systematicaly when you hit the go button
This kde build come from packman repository

-- Backtrace (Reduced):
#6  operator-> (this=0x0) at /usr/include/QtCore/qshareddata.h:79
#7  K3b::Device::Track::length (this=0x0) at /usr/src/debug/k3b-2.0.80.git20131118/libk3bdevice/k3btrack.cpp:95
#8  0x00000000004cf915 in K3b::AudioRipJob::trackLength (this=<optimized out>, trackIndex=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3baudioripjob.cpp:282
#9  0x00000000004df009 in K3b::MassAudioEncodingJob::run (this=0x36c58e0) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3bmassaudioencodingjob.cpp:205
#10 0x00007fe6c3a222f5 in K3b::Thread::run (this=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/libk3b/core/k3bthread.cpp:62

Created attachment 84169 [details]
New crash information added by DrKonqi

k3b (2.0.80) on KDE Platform 4.10.5 "release 1" using Qt 4.8.4

- What I was doing when the application crashed:
Identical to prevoius, new information, this on openSUSE 12.3, 12.2 (both x86_64) and openSUSE 12.2 i586

-- Backtrace (Reduced):
#5  operator-> (this=0x0) at /usr/include/QtCore/qshareddata.h:79
#6  K3b::Device::Track::length (this=0x0) at /usr/src/debug/k3b-2.0.80.git20131118/libk3bdevice/k3btrack.cpp:95
#7  0x00000000004cf915 in K3b::AudioRipJob::trackLength (this=<optimized out>, trackIndex=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3baudioripjob.cpp:282
#8  0x00000000004df009 in K3b::MassAudioEncodingJob::run (this=0x18ee9a0) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3bmassaudioencodingjob.cpp:205
#9  0x00007f8b200882f5 in K3b::Thread::run (this=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/libk3b/core/k3bthread.cpp:62

I can confirm this bug. Generated a backtrace, but on sending it Dr Konqi found that the bug was already reported.

Why is it still "unconfirmed"? I see several users having the same problem here...

Created attachment 84189 [details]
New crash information added by DrKonqi

k3b (2.0.80) on KDE Platform 4.10.5 "release 1" using Qt 4.8.4

- What I was doing when the application crashed:
Just clicked 'start ripping' in the 'CD Ripping - K3B' pop-up
CDDB had already automatically loaded.

- Unusual behavior I noticed:
None

- Custom settings of the application:
K3B was using my configured options for lame.
lame -V 3 -r --bitwidth 16 --little-endian -s 44.1 -h --tt %t --ta %a --tl %m --ty %y --tc %c --tn %n - %f

I don't think my lame config matters, K3B does not get as far as creating the directory for the output files - so it has not even tried to create any intermediate audio files.

Target folder was 
/share/grahams_music_share

File naming:
%A/%T/%n - !a='%A'{%a - }%t

I also tried ripping to raw, and the same thing happened.

-- Backtrace (Reduced):
#5  operator-> (this=0x0) at /usr/include/QtCore/qshareddata.h:79
#6  K3b::Device::Track::length (this=0x0) at /usr/src/debug/k3b-2.0.80.git20131118/libk3bdevice/k3btrack.cpp:95
#7  0x00000000004cf915 in K3b::AudioRipJob::trackLength (this=<optimized out>, trackIndex=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3baudioripjob.cpp:282
#8  0x00000000004df009 in K3b::MassAudioEncodingJob::run (this=0x1b1f2a0) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3bmassaudioencodingjob.cpp:205
#9  0x00007faabefed2f5 in K3b::Thread::run (this=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/libk3b/core/k3bthread.cpp:62

*** Bug 328840 has been marked as a duplicate of this bug. ***

*** Bug 329502 has been marked as a duplicate of this bug. ***

It has been almost two months after this bug is reported. Is anyone looking into it? Can we do anything ourselves to help annihilating it?

k3b currently has no maintainer. If you can git bisect the commit that broke it, please add a comment.

Hi Christopher, thanks for your comment. I'm very unsure if I'm up to that. I have the k3b git sources, so I could try. But I'd have to study git, and find out how to find out which commit broke k3b in this respect.

I had this crash on mint16 after building k3b from latest source code because the system was not clean. I had left k3boggvorbisencoder.so from stock installation in /usr/lib/kde4 and it preceded in path /usr/local/lib/kde4 where make install puts newly built library. 
Are you sure that you don't have similar situation?

I didn't compile k3b myself, it is the stock version from openSuse 13.1. But to check, I moved the k3boggvorbisencoder.so to  /usr/local/lib64/kde4, but it didn't make a difference.

Workaround: Use dolphin file manager to rip audio CDs. Configure in systemsettings -> Multimedia -> Audio CDs, CDDB Retrieval. If CDDB retrieval doesn't work for your CDs, k3b can read CD text. Then ask it  to "Save CD Info Locally" . This will then be used by Dolphin.

Comment on attachment 84189 [details]
New crash information added by DrKonqi

>Application: k3b (2.0.80)
>KDE Platform Version: 4.10.5 "release 1"
>Qt Version: 4.8.4
>Operating System: Linux 3.7.10-1.16-desktop x86_64
>Distribution: "openSUSE 12.3 (x86_64)"
>
>-- Information about the crash:
>- What I was doing when the application crashed:
>Just clicked 'start ripping' in the 'CD Ripping - K3B' pop-up
>CDDB had already automatically loaded.
>
>- Unusual behavior I noticed:
>None
>
>- Custom settings of the application:
>K3B was using my configured options for lame.
>lame -V 3 -r --bitwidth 16 --little-endian -s 44.1 -h --tt %t --ta %a --tl %m --ty %y --tc %c --tn %n - %f
>
>I don't think my lame config matters, K3B does not get as far as creating the directory for the output files - so it has not even tried to create any intermediate audio files.
>
>Target folder was 
>/share/grahams_music_share
>
>File naming:
>%A/%T/%n - !a='%A'{%a - }%t
>
>I also tried ripping to raw, and the same thing happened.
>
>The crash can be reproduced every time.
>
>-- Backtrace:
>Application: K3b (k3b), signal: Segmentation fault
>Using host libthread_db library "/lib64/libthread_db.so.1".
>[Current thread is 1 (Thread 0x7faabf734840 (LWP 12372))]
>
>Thread 3 (Thread 0x7faaa68e7700 (LWP 12373)):
>#0  0x00007faab96854ed in poll () from /lib64/libc.so.6
>#1  0x00007faab46efaa4 in ?? () from /usr/lib64/libglib-2.0.so.0
>#2  0x00007faab46efbc4 in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
>#3  0x00007faabad392e6 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#4  0x00007faabad09adf in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#5  0x00007faabad09d68 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#6  0x00007faabac0c0f0 in QThread::exec() () from /usr/lib64/libQtCore.so.4
>#7  0x00007faabacea29f in ?? () from /usr/lib64/libQtCore.so.4
>#8  0x00007faabac0f0cc in ?? () from /usr/lib64/libQtCore.so.4
>#9  0x00007faab9390e0f in start_thread () from /lib64/libpthread.so.0
>#10 0x00007faab968e44d in clone () from /lib64/libc.so.6
>
>Thread 2 (Thread 0x7faa98c93700 (LWP 12500)):
>[KCrash Handler]
>#5  operator-> (this=0x0) at /usr/include/QtCore/qshareddata.h:79
>#6  K3b::Device::Track::length (this=0x0) at /usr/src/debug/k3b-2.0.80.git20131118/libk3bdevice/k3btrack.cpp:95
>#7  0x00000000004cf915 in K3b::AudioRipJob::trackLength (this=<optimized out>, trackIndex=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3baudioripjob.cpp:282
>#8  0x00000000004df009 in K3b::MassAudioEncodingJob::run (this=0x1b1f2a0) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3bmassaudioencodingjob.cpp:205
>#9  0x00007faabefed2f5 in K3b::Thread::run (this=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/libk3b/core/k3bthread.cpp:62
>#10 0x00007faabac0f0cc in ?? () from /usr/lib64/libQtCore.so.4
>#11 0x00007faab9390e0f in start_thread () from /lib64/libpthread.so.0
>#12 0x00007faab968e44d in clone () from /lib64/libc.so.6
>
>Thread 1 (Thread 0x7faabf734840 (LWP 12372)):
>#0  0x00007faab96815ed in read () from /lib64/libc.so.6
>#1  0x00007faab472be0f in ?? () from /usr/lib64/libglib-2.0.so.0
>#2  0x00007faab46ef634 in g_main_context_check () from /usr/lib64/libglib-2.0.so.0
>#3  0x00007faab46efa42 in ?? () from /usr/lib64/libglib-2.0.so.0
>#4  0x00007faab46efbc4 in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
>#5  0x00007faabad392c6 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#6  0x00007faab9ed7c1e in ?? () from /usr/lib64/libQtGui.so.4
>#7  0x00007faabad09adf in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#8  0x00007faabad09d68 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#9  0x00007faaba2eb9c8 in QDialog::exec() () from /usr/lib64/libQtGui.so.4
>#10 0x0000000000533108 in K3b::JobProgressDialog::startJob (this=0x7fff2fdcd0a0, job=0x1b1f2a0) at /usr/src/debug/k3b-2.0.80.git20131118/src/k3bjobprogressdialog.cpp:618
>#11 0x00000000004d5208 in K3b::AudioRippingDialog::slotStartClicked (this=0x7fff2fdce970) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3baudiorippingdialog.cpp:304
>#12 0x000000000053b0c6 in qt_static_metacall (_a=<optimized out>, _id=<optimized out>, _o=<optimized out>, _c=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/build/src/k3binteractiondialog.moc:138
>#13 K3b::InteractionDialog::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /usr/src/debug/k3b-2.0.80.git20131118/build/src/k3binteractiondialog.moc:102
>#14 0x00007faabad2029f in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /usr/lib64/libQtCore.so.4
>#15 0x00007faaba49c702 in QAbstractButton::clicked(bool) () from /usr/lib64/libQtGui.so.4
>#16 0x00007faaba1f104e in ?? () from /usr/lib64/libQtGui.so.4
>#17 0x00007faaba1f1880 in ?? () from /usr/lib64/libQtGui.so.4
>#18 0x00007faaba1f1aec in QAbstractButton::mouseReleaseEvent(QMouseEvent*) () from /usr/lib64/libQtGui.so.4
>#19 0x00007faab9e87149 in QWidget::event(QEvent*) () from /usr/lib64/libQtGui.so.4
>#20 0x00007faab9e3786c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
>#21 0x00007faab9e3c54b in QApplication::notify(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
>#22 0x00007faabe8ed7f6 in KApplication::notify(QObject*, QEvent*) () from /usr/lib64/libkdeui.so.5
>#23 0x00007faabad0ad8e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib64/libQtCore.so.4
>#24 0x00007faab9e386ab in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) () from /usr/lib64/libQtGui.so.4
>#25 0x00007faab9eb2e94 in ?? () from /usr/lib64/libQtGui.so.4
>#26 0x00007faab9eb1c21 in QApplication::x11ProcessEvent(_XEvent*) () from /usr/lib64/libQtGui.so.4
>#27 0x00007faab9ed7fa2 in ?? () from /usr/lib64/libQtGui.so.4
>#28 0x00007faab46ef7d5 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
>#29 0x00007faab46efb08 in ?? () from /usr/lib64/libglib-2.0.so.0
>#30 0x00007faab46efbc4 in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
>#31 0x00007faabad392e6 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#32 0x00007faab9ed7c1e in ?? () from /usr/lib64/libQtGui.so.4
>#33 0x00007faabad09adf in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#34 0x00007faabad09d68 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#35 0x00007faaba2eb9c8 in QDialog::exec() () from /usr/lib64/libQtGui.so.4
>#36 0x000000000053aea4 in K3b::InteractionDialog::exec (this=0x7fff2fdce970) at /usr/src/debug/k3b-2.0.80.git20131118/src/k3binteractiondialog.cpp:496
>#37 0x00000000004d6e2f in K3b::AudioCdView::startRip (this=0x127cff0) at /usr/src/debug/k3b-2.0.80.git20131118/src/rip/k3baudiocdview.cpp:335
>#38 0x00007faabad2029f in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /usr/lib64/libQtCore.so.4
>#39 0x00007faab9e31662 in QAction::triggered(bool) () from /usr/lib64/libQtGui.so.4
>#40 0x00007faab9e31850 in QAction::activate(QAction::ActionEvent) () from /usr/lib64/libQtGui.so.4
>#41 0x00007faaba1f183f in ?? () from /usr/lib64/libQtGui.so.4
>#42 0x00007faaba1f1aec in QAbstractButton::mouseReleaseEvent(QMouseEvent*) () from /usr/lib64/libQtGui.so.4
>#43 0x00007faaba2abe1a in QToolButton::mouseReleaseEvent(QMouseEvent*) () from /usr/lib64/libQtGui.so.4
>#44 0x00007faab9e87149 in QWidget::event(QEvent*) () from /usr/lib64/libQtGui.so.4
>#45 0x00007faab9e3786c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
>#46 0x00007faab9e3c54b in QApplication::notify(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
>#47 0x00007faabe8ed7f6 in KApplication::notify(QObject*, QEvent*) () from /usr/lib64/libkdeui.so.5
>#48 0x00007faabad0ad8e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib64/libQtCore.so.4
>#49 0x00007faab9e386ab in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) () from /usr/lib64/libQtGui.so.4
>#50 0x00007faab9eb2e94 in ?? () from /usr/lib64/libQtGui.so.4
>#51 0x00007faab9eb1c21 in QApplication::x11ProcessEvent(_XEvent*) () from /usr/lib64/libQtGui.so.4
>#52 0x00007faab9ed7fa2 in ?? () from /usr/lib64/libQtGui.so.4
>#53 0x00007faab46ef7d5 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
>#54 0x00007faab46efb08 in ?? () from /usr/lib64/libglib-2.0.so.0
>#55 0x00007faab46efbc4 in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
>#56 0x00007faabad392e6 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#57 0x00007faab9ed7c1e in ?? () from /usr/lib64/libQtGui.so.4
>#58 0x00007faabad09adf in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#59 0x00007faabad09d68 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
>#60 0x00007faabad0ea08 in QCoreApplication::exec() () from /usr/lib64/libQtCore.so.4
>#61 0x0000000000449937 in main (argc=1, argv=0x7fff2fdd0248) at /usr/src/debug/k3b-2.0.80.git20131118/src/main.cpp:146
>
>Possible duplicates by query: bug 328258.
>
>Reported using DrKonqi

I am on KDE 4.11.5 now (k3b version is still 2.0.80), and the bug seems solved. At least, k3b does the ripping perfectly now. Don't know when exact the improvement came, I didn't try it for a long time.

Anyway, thanks to whom is responsible for this!

Git commit 36a0d951149bba282297aa1c94a0e318db85788f by Johannes Obermayr.
Committed on 14/08/2014 at 21:30.
Pushed by jobermayr into branch 'master'.

Don't start ripping if init() fails.

This bug was hidden after I made library loading working again (commit e1a40d7).

M  +2    -1    src/rip/k3bmassaudioencodingjob.cpp

http://commits.kde.org/k3b/36a0d951149bba282297aa1c94a0e318db85788f