Summary: | crash when changing owner in start new game dialogue | ||
---|---|---|---|
Product: | [Applications] konquest | Reporter: | Alexander Schuch <aschuch247> |
Component: | general | Assignee: | Pierre Ducroquet <pinaraf> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | kde-games-bugs, reeves.87 |
Priority: | NOR | ||
Version: | 2.1 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/konquest/c53883f622744b737f388cc2d72a0f74bd1d8598 | Version Fixed In: | 4.11.5 |
Description
Alexander Schuch
2013-11-30 01:44:36 UTC
Fix up for review at https://git.reviewboard.kde.org/r/114232 Git commit c937b221a2d0c49833c43dd46b9c64ad9d0644ba by Alexander Schuch. Committed on 07/12/2013 at 18:21. Pushed by aschuch into branch 'KDE/4.11'. Disable planet owner combo box if required. Changing the owner of a planet in new game dialogue currently crashes if the selected planet moves off the map due to a resize. Steps to reproduce are in the bug report. This patch makes owner combo box follow same rules for enabling as production and kill percentage. Patched by Michael Reeves. This is implemented in Konquest 2.1. FIXED-IN: 4.11 REVIEW: 114232 M +2 -0 dialogs/newgamedlg.cc http://commits.kde.org/konquest/c937b221a2d0c49833c43dd46b9c64ad9d0644ba Git commit 285d5ea5a893a3b16a901be9a08bf4e49e0d7dfc by Alexander Schuch. Committed on 07/12/2013 at 18:21. Pushed by aschuch into branch 'KDE/4.12'. Disable planet owner combo box if required. Changing the owner of a planet in new game dialogue currently crashes if the selected planet moves off the map due to a resize. Steps to reproduce are in the bug report. This patch makes owner combo box follow same rules for enabling as production and kill percentage. Patched by Michael Reeves. This is implemented in Konquest 2.1. FIXED-IN: 4.11 REVIEW: 114232 (cherry picked from commit c937b221a2d0c49833c43dd46b9c64ad9d0644ba) M +2 -0 dialogs/newgamedlg.cc http://commits.kde.org/konquest/285d5ea5a893a3b16a901be9a08bf4e49e0d7dfc Git commit c53883f622744b737f388cc2d72a0f74bd1d8598 by Alexander Schuch. Committed on 07/12/2013 at 18:21. Pushed by aschuch into branch 'master'. Disable planet owner combo box if required. Changing the owner of a planet in new game dialogue currently crashes if the selected planet moves off the map due to a resize. Steps to reproduce are in the bug report. This patch makes owner combo box follow same rules for enabling as production and kill percentage. Patched by Michael Reeves. This is implemented in Konquest 2.1. FIXED-IN: 4.11 REVIEW: 114232 (cherry picked from commit c937b221a2d0c49833c43dd46b9c64ad9d0644ba) (cherry picked from commit 285d5ea5a893a3b16a901be9a08bf4e49e0d7dfc) M +2 -0 dialogs/newgamedlg.cc http://commits.kde.org/konquest/c53883f622744b737f388cc2d72a0f74bd1d8598 |