Bug 328097

Summary:	cvs commits messages wrapped with single quote
Product:	[Developer tools] kdevplatform	Reporter:	stompdagger1
Component:	cvs	Assignee:	kdevelop-bugs-null
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	mail
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	fix using latter solution (simpler) updated version that compiles

Description stompdagger1 2013-11-26 08:21:29 UTC

when commiting files to cvs, actual cvs commad generated by kdevplatform is the following:
cvs commit -m 'msg' files
this is worng as the ' are embedded in the msg and they shouldn't, the proper format should be
cvs commit -m "msg" files

the reason for is that KShell::quoteArg is used and it wraps the msg.

there are two ways to fix it, the proper way is to add KShell::doubleQuoteArg that wraps the msg in double quotes.

the simple way is to replace the single quote with double quote.

Reproducible: Always

Comment 1 stompdagger1 2013-11-26 08:22:34 UTC

Created attachment 83769 [details]
fix using latter solution (simpler)

here is a patch that should fix it localy (not in kshell), didn't got to test it thought

Comment 2 stompdagger1 2013-11-26 08:53:20 UTC

Created attachment 83771 [details]
updated version that compiles

previous patch didn't compiled

Comment 3 Milian Wolff 2013-11-26 13:25:05 UTC

But then, if your message contains double quotes, it would fail - no?

Also, please put patches on reviewboard and run the tests and - if possible - also add a test for this issue.

Comment 4 stompdagger1 2013-11-26 15:25:31 UTC

(In reply to comment #3)
> But then, if your message contains double quotes, it would fail - no?
nope, it doesn't thing is, it adds the double quotes to the msg which us strange.
> 
> Also, please put patches on reviewboard and run the tests and - if possible
> - also add a test for this issue.
my patch doesn't solves if, I need t ocheck why is that, will update when I'll find a better patch.

Comment 5 Andrew Crouthamel 2018-11-11 04:26:16 UTC

Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!

Comment 6 Andrew Crouthamel 2018-11-21 04:25:41 UTC

Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!

Comment 7 Francis Herne 2020-08-18 18:20:37 UTC

The CVS plugin was removed in KDevelop 5.3 because it was unmaintained and didn't work in most cases.