Bug 328038

Summary: add im-sipe icons
Product: [Unmaintained] telepathy Reporter: Maksim Melnikau <maxposedon>
Component: common-internalsAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED UNMAINTAINED    
Severity: wishlist CC: kde, mklapetek
Priority: NOR    
Version: unspecified   
Target Milestone: 0.8.0   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: hi16-action-im-sipe.png
hi22-action-im-sipe.png
hi32-action-im-sipe.png
hi48-action-im-sipe.png

Description Maksim Melnikau 2013-11-24 22:46:04 UTC
Add im-sipe icons, I took them from pidgin-sipe source tree

Reproducible: Always
Comment 1 Maksim Melnikau 2013-11-24 22:47:15 UTC
Created attachment 83742 [details]
hi16-action-im-sipe.png
Comment 2 Maksim Melnikau 2013-11-24 22:47:46 UTC
Created attachment 83743 [details]
hi22-action-im-sipe.png
Comment 3 Maksim Melnikau 2013-11-24 22:48:12 UTC
Created attachment 83744 [details]
hi32-action-im-sipe.png
Comment 4 Maksim Melnikau 2013-11-24 22:50:10 UTC
Created attachment 83745 [details]
hi48-action-im-sipe.png
Comment 5 David Edmundson 2013-11-25 10:53:28 UTC
If pidgin-sipe installs them, why do we have to? 
Can we not set the .profile file to use the same icon name?
Comment 6 Maksim Melnikau 2013-11-25 11:31:47 UTC
(In reply to comment #5)
> If pidgin-sipe installs them, why do we have to? 
> Can we not set the .profile file to use the same icon name?
because, pidgin-sipe installs than in a bit strange place

% equery f pidgin-sipe | grep im-sipe
/usr/share/empathy/icons/hicolor/16x16/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/22x22/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/24x24/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/32x32/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/48x48/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/scalable/apps/im-sipe.svg
Comment 7 Martin Klapetek 2013-11-25 11:34:02 UTC
Yes, that's quite strange place. Is it the source that installs it there or the distro package?
Comment 8 David Edmundson 2013-11-25 11:36:22 UTC
OK, so this will work if we do a KIconLoader::addAppDir("empathy") somewhere globally (so every KTp app has it) 

or we ship duplicate icons, I'm not sure which is the lesser of two evils
Comment 9 Maksim Melnikau 2013-11-25 11:42:01 UTC
(In reply to comment #7)
> Yes, that's quite strange place. Is it the source that installs it there or
> the distro package?

This is default path from pidgin-sipe package, yep it looks like upstream (pidgin-sipe) issue, but I'm not sure when they will fix it, if bug will be opened.

./contrib/rpm/pidgin-sipe.spec contains
%{_datadir}/empathy/icons/hicolor/*/apps/im-sipe.png
%{_datadir}/empathy/icons/hicolor/*/apps/im-sipe.svg

pixmaps/Makefile.common.am contains
if SIPE_INCLUDE_TELEPATHY
empathyappsiconsdir    = $(datadir)/empathy/icons/hicolor/$(pixmapinst)/apps
empathyappsicons_DATA  = im-sipe.$(pixmapext)
DISTCLEANFILES         = im-sipe.$(pixmapext)
Comment 10 Maksim Melnikau 2013-11-25 11:45:20 UTC
frankly speaking , pidgin-sipe - is the only one who installs icons on my system is so strange place... And I want to remind one more issue:

pidgin-sipe installs this icons ONLY when it compiled in telepathy mode. If pidgin sipe compiled without telepathy, and users use sipe via haze - no any sipe icons installed! 

So, I still think that ktp-common-internals should provide sipe icon.
Comment 11 Maksim Melnikau 2013-11-25 11:46:48 UTC
even more. pidgin-sipe just copy-paste icons in many places

/usr/share/empathy/icons/hicolor/16x16/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/22x22/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/24x24/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/32x32/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/48x48/apps/im-sipe.png
/usr/share/empathy/icons/hicolor/scalable/apps/im-sipe.svg
/usr/share/pixmaps/pidgin/protocols/16/sipe.png
/usr/share/pixmaps/pidgin/protocols/22/sipe.png
/usr/share/pixmaps/pidgin/protocols/24/sipe.png
/usr/share/pixmaps/pidgin/protocols/32/sipe.png
/usr/share/pixmaps/pidgin/protocols/48/sipe.png
/usr/share/pixmaps/pidgin/protocols/scalable/sipe.svg
Comment 12 Martin Klapetek 2013-11-25 14:16:38 UTC
I think this should be fixed upstream, either pidgin-sipe directly or at least at a distro level. If we'd install that icon too, it would be just more pointless copying around and basically just a workaround to the original problem, which is wrong install directory for those icons.

So, please let's fix this properly where it should be fixed.
Comment 13 David Edmundson 2013-11-25 14:26:11 UTC
I agree we should email first, if upstream cause a problem - then we can look at workarounds.

Maksim, are you happy to email them?
Comment 14 Maksim Melnikau 2013-12-26 21:38:22 UTC
(In reply to comment #13)
> Maksim, are you happy to email them?
I would like to ask you (ktp team) to handle this, you understand entirely this situation better than I'm...
Comment 15 Maksim Melnikau 2014-01-04 21:22:04 UTC
I would like to re-open this, because situation not properly handled, e.g.
1. ktp team could ask pidgin-sipe team about images path
2. in haze/sipe mode, when pidgin-sipe compiled with --disable-telepathy, images not installed at all
Comment 16 Martin Klapetek 2014-01-04 21:38:01 UTC
Given we're building the sipe plugin unconditionally, let's just ship the icons with KTp. There can be just too many things going wrong and having couple small files duplicated on a disk is not a problem.
Comment 17 Christoph Cullmann 2024-09-18 18:14:34 UTC
Dear user, unfortunately Telepathy is no longer maintained.

Please migrate to another solution, e.g. for Jabber a possibility is Kaidan, for Matrix a candidate is NeoChat.