| Summary: | Krita crashes when applying GMIC filter | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tepee <inscription> |
| Component: | G'Mic for Krita | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, halla, lukast.dev |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 2.8 Pre-Alpha | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/2fc8ce8f1d62289017382728a4a1f46a1b714a25 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Tepee
2013-11-23 16:07:59 UTC
Did you use single layer image? qFatal(char const*, ...) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #10 0x00007fa7a8f1768a in KisGmicSimpleConvertor::convertToGmicImageFast (dev=..., gmicImage=..., rc=...) at /build/buildd/krita-testing-2+git20131115+r74371-45/krita/plugins/extensions/gmic/kis_gmic_simple_convertor.cpp:445 There it checks if the tile has width and height 64 pixel. Was that changed lately? I cannot reproduce it No, the tilesize hasn't changed: kis_tile_data_interface.h:#define __TILE_DATA_WIDTH 64 kis_tile_data_interface.h:#define __TILE_DATA_HEIGHT 64 But I am not sure that numContiguousColumns will always return the tilesize. I think we need the original file, or at least its dimensions to reproduce. numContiguousColumns() will return a value in a range 0...64, depending on the current position of an iterator. Git commit 64883cd1e1f1a5e4d12a781c5d6612489d79316f by Boudewijn Rempt. Committed on 18/12/2013 at 09:52. Pushed by rempt into branch 'calligra/2.8'. Temporarily disable the fast paint device conversion It uses nconseq rows and cols the wrong way, so go to the fallback for now. Note: not to be forward-ported to master. M +3 -1 krita/plugins/extensions/gmic/kis_gmic_simple_convertor.cpp http://commits.kde.org/calligra/64883cd1e1f1a5e4d12a781c5d6612489d79316f Lukas still needs to work on the fast transfer code, but it's not a crash anymore Git commit 89029f6c4c2c72bd85f8bd05403327ca0c4f53e5 by Lukáš Tvrdý. Committed on 26/04/2014 at 14:56. Pushed by lukast into branch 'master'. GMIC: Fix crash when filter is applied to the layer which was moved - the computation of tile width was buggy - scaling pixels to float color-space in temporary tile did not take into account the posibility that the source tile is read only partially (when you e.g. selection) - there is still some corruption when bitblting gmic result to layer Related: bug 325771 M +46 -25 krita/plugins/extensions/gmic/kis_gmic_simple_convertor.cpp http://commits.kde.org/calligra/89029f6c4c2c72bd85f8bd05403327ca0c4f53e5 Git commit a9a6add1cd1ac517c207c15c3efd19ec3fc5cd9c by Boudewijn Rempt, on behalf of Lukáš Tvrdý. Committed on 26/04/2014 at 14:56. Pushed by rempt into branch 'calligra/2.8'. GMIC: Fix crash when filter is applied to the layer which was moved - the computation of tile width was buggy - scaling pixels to float color-space in temporary tile did not take into account the posibility that the source tile is read only partially (when you e.g. selection) - there is still some corruption when bitblting gmic result to layer Related: bug 325771 M +46 -25 krita/plugins/extensions/gmic/kis_gmic_simple_convertor.cpp http://commits.kde.org/calligra/a9a6add1cd1ac517c207c15c3efd19ec3fc5cd9c Git commit 2fc8ce8f1d62289017382728a4a1f46a1b714a25 by Boudewijn Rempt, on behalf of Lukáš Tvrdý. Committed on 26/04/2014 at 14:56. Pushed by dickson into tag 'steam-247500_247566'. GMIC: Fix crash when filter is applied to the layer which was moved - the computation of tile width was buggy - scaling pixels to float color-space in temporary tile did not take into account the posibility that the source tile is read only partially (when you e.g. selection) - there is still some corruption when bitblting gmic result to layer Related: bug 325771 M +46 -25 krita/plugins/extensions/gmic/kis_gmic_simple_convertor.cpp http://commits.kde.org/calligra/2fc8ce8f1d62289017382728a4a1f46a1b714a25 |