Bug 327932

Summary:	Lame encoding quality is set by spinbox, but labels suggest slider
Product:	[Applications] k3b	Reporter:	Jeffery MacEachern <j.maceachern>
Component:	Plugins	Assignee:	Jeffery MacEachern <j.maceachern>
Status:	RESOLVED FIXED
Severity:	minor	CC:	cfeck, trueg
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	2.0.2
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	3955c88b72bc4781910c5d61b1d18b5d58bad2ff	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Image for clarity

Description Jeffery MacEachern 2013-11-22 10:21:17 UTC

Just a usability issue.

Reproducible: Always

Steps to Reproduce:
1. Open Settings -> Plugins; select Configure button for Lame MP3 Encoder
2. Switch to Advanced tab
Actual Results:  
The Encoder Quality is set by a spinbox, but there are labels underneath ("fast encoding" / "high quality") on opposite sides.

Expected Results:  
Either the labels would be removed, since there is no mapping between them and the value in a spinbox, or the spinbox would be replaced with a slider as with the Quality Settings slider/labels in the main (Settings) tab of the dialog.

Comment 1 Jeffery MacEachern 2013-11-22 10:22:00 UTC

Created attachment 83696 [details]
Image for clarity

Comment 2 Christoph Feck 2013-11-23 11:58:05 UTC

Yep, there is code to enable the slider, but it is used wrong. Easy to fix, marking as a junior-job.

Comment 3 Jeffery MacEachern 2013-11-25 02:32:34 UTC

This has been committed now as 3955c88b72bc4781910c5d61b1d18b5d58bad2ff. I didn't find out about the commit hook keywords until after. Sorry for the bother. Marking as Resolved now.

Comment 4 Christoph Feck 2013-11-25 23:32:47 UTC

Thanks Jeffery. Please understand that k3b currently has no maintainer, so that no official release is to be expected to include your fix, unless someone steps up volunteering.