Summary: | [PATCH] valgrind 3.9.0 build fails on Mac OS X 10.6.8 | ||
---|---|---|---|
Product: | [Developer tools] valgrind | Reporter: | Mark H <mh8928> |
Component: | general | Assignee: | Rhys Kidd <rhyskidd> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | erg, rhyskidd |
Priority: | NOR | ||
Version: | 3.9.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | macOS | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Fix syscall conditionals OS X 10.6.8
Rebased patch against r15443 |
Description
Mark H
2013-11-18 05:38:03 UTC
Created attachment 83614 [details]
Fix syscall conditionals OS X 10.6.8
Corrects #if conditions and 10.6.8 build failure
Can you re-try with the trunk? I do remember making some of these versioning ifdefs a bit tidier a couple of months back. That said .. 10.6.8 is a bit old. The trunk supports 10.8 and 10.9 reasonably well. Can you use those instead? I tried the trunk (r14461) and also valgrind-3.10.0.BETA1 on my OS X 10.6.8 system. However, both produced the exact same undefined symbol errors as 3.9.0, shown in the bug description. OS X 10.8 and 10.9 do not run on this hardware. *** Bug 330984 has been marked as a duplicate of this bug. *** Hello Mark, I'll take a look at this. Is your attached patch the most current one you have available? Created attachment 93718 [details]
Rebased patch against r15443
Hello Mark, I've rebased your patch and completing some final testing before merging in the next few days. Two main issues: * Clarifying gettid (syscall 286), which was a merge conflict. Based on xnu sources this was in fact present in OS X 10.6, which will need to be amended in SVN trunk. * Don't have any actual 10.6 system to test with, but provided there are no regressions on OS X 10.7+ will be happy to merge if it is going to fix build issues for you. Committed in r15444. |