Bug 327690

Summary:	Bogus path for Qt Designer plugins
Product:	[Applications] marble	Reporter:	Kevin Kofler <kevin.kofler>
Component:	general	Assignee:	marble-bugs
Status:	RESOLVED FIXED
Severity:	grave	CC:	rdieter
Priority:	NOR
Version:	1.7 (KDE 4.12)
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
URL:	https://projects.kde.org/projects/kde/kdeedu/marble/repository/revisions/2773f06af5f57563d5c5c8e0ea8e74d56c8300bb
Latest Commit:	http://commits.kde.org/marble/18e5abc204cd81363eb1e182f39ce8fc2fb9a226	Version Fixed In:
Sentry Crash Report:

Description Kevin Kofler 2013-11-16 17:11:21 UTC

The following commit:
https://projects.kde.org/projects/kde/kdeedu/marble/repository/revisions/2773f06af5f57563d5c5c8e0ea8e74d56c8300bb
changes the install path for Qt Designer plugins to a directory below the MARBLE_PLUGIN_INSTALL_PATH. (On Fedora, this ends up to be /usr/lib(64)/kde4/plugins/marble/plugins/designer, but it is probably broken everywhere.) This is not going to work. Qt Designer plugins need to end up somewhere Qt Designer actually looks for them.

Reproducible: Always

Steps to Reproduce:
1. Build and install Marble.
Actual Results:  
The Qt Designer plugins end up in an incorrect location.

Expected Results:  
The Qt Designer plugins end up in a directory in Qt Designer's search path.

Please revert the offending commit.

Comment 1 Rex Dieter 2013-11-16 18:02:38 UTC

confirmed

Comment 2 Dennis Nienhüser 2013-11-17 10:51:14 UTC

Git commit 77546c4a76f67671332985a3949bf6a24106333f by Dennis Nienhüser.
Committed on 17/11/2013 at 10:44.
Pushed by nienhueser into branch 'master'.

Revert "Reuse MARBLE_PLUGIN_INSTALL_PATH."

Note that this will break a cmake install when using a local
install path and QTONLY=TRUE, so needs a better approach in
the future. Workarounds are using sudo/root for make install
or disabling designer plugins (WITH_DESIGNER_PLUGIN=FALSE)

This reverts commit 2773f06af5f57563d5c5c8e0ea8e74d56c8300bb.

M  +2    -2    MarbleMacros.cmake

http://commits.kde.org/marble/77546c4a76f67671332985a3949bf6a24106333f

Comment 3 Dennis Nienhüser 2013-11-17 11:05:06 UTC

Git commit 18e5abc204cd81363eb1e182f39ce8fc2fb9a226 by Dennis Nienhüser.
Committed on 17/11/2013 at 11:03.
Pushed by nienhueser into branch 'KDE/4.12'.

Revert "Reuse MARBLE_PLUGIN_INSTALL_PATH."

Note that this will break a cmake install when using a local
install path and QTONLY=TRUE, so needs a better approach in
the future. Workarounds are using sudo/root for make install
or disabling designer plugins (WITH_DESIGNER_PLUGIN=FALSE)

This reverts commit 2773f06af5f57563d5c5c8e0ea8e74d56c8300bb.

M  +2    -2    MarbleMacros.cmake

http://commits.kde.org/marble/18e5abc204cd81363eb1e182f39ce8fc2fb9a226