Bug 327530

Summary:	can't add a Dektop Widget from Widget Browser because apps aren't minimized
Product:	[Plasma] plasmashell	Reporter:	rockonthemoonfm
Component:	Widget Explorer sidebar	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	anaceciliamb, kde, leszek.lesner, thomas.pfeiffer
Priority:	NOR	Flags:	rockonthemoonfm: VisualDesign+
Version:	master
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:	http://commits.kde.org/plasma-desktop/1aab04cec1c479d68171216b877d1b91a7af5adc	Version Fixed In:	5.6.0
Sentry Crash Report:

Description rockonthemoonfm 2013-11-12 21:48:41 UTC

hi,
while having my browser fullscreen an many other apps behind it, i wanted to add a Desktop Widget. I unlocked the Panel (right-click on Panel, not through Toolbox: it is NULL when an app is fullscreen), I went to Add Widget, but i realized that i couldn't add a Widget to Desktop simply because apps weren't minimized. 

You can't manage widgets if apps are displayed.
You can't d'n'd widgets from browser to desktop with shown apps.
So, minimize windows on "Add Widgets" click seems a correct solution, same as in clicking Toolbox. 

Reproducible: Always

Steps to Reproduce:
1. maximize a window
2. click on "add Widgets"
3. add widget from browser to desktop
Actual Results:  
can't add or manage Desktop widgets  because of shown windows


Expected Results:  
all windows are minimized on "Add Widget" click.
Windows could be restored if no action has been taken.

proposed fix for Plasma-Next too

Comment 1 Thomas Pfeiffer 2016-01-30 23:28:04 UTC

Confirmed, the problem is real.

As an alternative solution I'd suggest to only temporarily hide windows while a widget is being dragged out of the Widget Explorer.

This is another problem which would be fixed by a Plasma Config Mode, so either we fix this symptom or we fix the underlying problem.

Comment 2 Kai Uwe Broulik 2016-01-31 00:21:59 UTC

I guess we could initiate show desktop mode ("minimize all") when you start dragging a widget.

Comment 3 Kai Uwe Broulik 2016-02-01 15:36:02 UTC

Git commit 1aab04cec1c479d68171216b877d1b91a7af5adc by Kai Uwe Broulik.
Committed on 01/02/2016 at 15:35.
Pushed by broulik into branch 'master'.

[Widget Explorer] Show desktop on dragging widget

When starting to drag a widget, show desktop mode is enabled causing all windows
but the widget explorer to disappear.

Windows are only restored when widget explorer closes, not as soon as you drop it,
so you can see where you dropped the widget and configure it right away.

REVIEW: 126938
FIXED-IN: 5.6.0

M  +1    -0    desktoppackage/contents/explorer/AppletDelegate.qml
M  +11   -0    desktoppackage/contents/explorer/WidgetExplorer.qml

http://commits.kde.org/plasma-desktop/1aab04cec1c479d68171216b877d1b91a7af5adc

Comment 4 Leszek Lesner 2016-02-06 00:48:37 UTC

Does this patch need a newer KF5 version ? 
On KF5Windowsystem 5.18 it throws the error:
file:///usr/share/plasma/shells/org.kde.plasma.desktop/contents/explorer/AppletDelegate.qml:51: TypeError: Cannot assign to read-only property "showingDesktop"
file:///usr/share/plasma/shells/org.kde.plasma.desktop/contents/explorer/WidgetExplorer.qml:54: TypeError: Cannot assign to read-only property "showingDesktop"

Comment 5 Kai Uwe Broulik 2016-02-06 09:40:09 UTC

Yes, this requires the following patch in KDeclarative: https://quickgit.kde.org/?p=kdeclarative.git&a=commit&h=8ea478dbcc3349dd421ac64fc5263801d6859185