Summary: | "Previous conversation" link point to message after current one instead of before message | ||
---|---|---|---|
Product: | [Unmaintained] telepathy | Reporter: | Ezio Vergine <virgolus> |
Component: | log-viewer | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dvratil, kde, mklapetek |
Priority: | NOR | ||
Version: | 0.7.0 | ||
Target Milestone: | Future | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/telepathy-text-ui/f53b27104724687861ebb35213356799ac24b62d | Version Fixed In: | 0.7.1 |
Sentry Crash Report: |
Description
Ezio Vergine
2013-11-11 00:15:29 UTC
Confirmed, we just tested. "Next conversation" goes to "next" in the list of conversations which you have on the side, so in that sense it's correct. However it is a bit misleading. Simple solution could be to reverse-sort the side list, but having the most recent conversation on top is imho good. We just need to reword the strings. "Newer" and "Older" conversations maybe? I think the best solution would be this: - sort of conversations on the side is ok (top - newer, bottom - older) - in chat the button are, as you proposed: Older conversation [.... chat log ..,] Newer conversation - Older conversation -> go to previous (in date) chat log - Newer conversation -> go to next (in date) chat log Bye Since we can't change translations in 0.7, I propose this: - in 0.7 branch I swap the strings so that "Previous conversation" points to messages before the current one - in 0.8 branch I update the strings to "Older Conversation"/"Newer Conversation" Everyone OK with that? Ok for me. Thanx 0.8 may be really soon - I'd be happy with you fixing this in just 0.8.0 As some recently released distros (openSuse, Kubuntu...) ship 0.7 and won't accept 0.8 into main repos, please let's fix it in 0.7 too. Unless there won't be anymore 0.7.x releases. Git commit c92dde59b42b16dbe4f8c1004233d1a970f9498e by Dan Vrátil. Committed on 22/11/2013 at 10:44. Pushed by dvratil into branch 'kde-telepathy-0.7'. Swap Previous and Next Conversation links in LogViewer As pointed out, they make more sense this way. FIXED-IN: 0.7.1 M +4 -4 logviewer/message-view.cpp http://commits.kde.org/telepathy-text-ui/c92dde59b42b16dbe4f8c1004233d1a970f9498e Git commit f53b27104724687861ebb35213356799ac24b62d by Dan Vrátil. Committed on 22/11/2013 at 11:21. Pushed by dvratil into branch 'master'. Improve Previous/Next Conversation links in LogViewer Use Older/Newer Conversation instead, as it's more clear that way M +2 -2 logviewer/message-view.cpp http://commits.kde.org/telepathy-text-ui/f53b27104724687861ebb35213356799ac24b62d |