| Summary: | Automatic album generation produces only lower case album / folder names | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Rico <kde> |
| Component: | Import-PostProcessing | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, kde, tpr |
| Priority: | NOR | ||
| Version: | 3.4.0 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/36203280f48eb2e04ecc0b95d41597b2f16eacac | Version Fixed In: | 5.4.0 |
| Sentry Crash Report: | |||
|
Description
Rico
2013-11-06 19:59:43 UTC
The directory name is lowercased in digikam/utilities/importui/main/importui.cpp's createDateBasedSubAlbum() and there's this comment there: // See B.K.O #136927 : we need to support file system which do not // handle upper case properly. Should there be a check for target filesystem's case-sensitivity support? yes, but how to do it ? bu Qt or KDE API ? investigation are required here... Gilles I think there's no need nowadays for undercasing the paths From my quick tests on Arch with a test file, the original problems sounds like a mounting problem of the distribution or that things have changed since then. You can try the following: tuli:/tmp:% dd if=/dev/zero of=fat32.disk bs=1K count=1M 1048576+0 records in 1048576+0 records out 1073741824 bytes (1.1 GB) copied, 0.89088 s, 1.2 GB/s tuli:/tmp:% mkfs.vfat fat32.disk mkfs.fat 3.0.23 (2013-10-15) tuli:/tmp:% mkdir fattest mkdir: cannot create directory ‘fattest’: File exists tuli:/tmp:% rm -rf fattest tuli:/tmp:% mkdir fattest tuli:/tmp:% sudo mount fat32.disk fattest tuli:/tmp:% mkdir fattest/FOO mkdir: cannot create directory ‘fattest/FOO’: Permission denied tuli:/tmp:% sudo !! tuli:/tmp:% sudo mkdir fattest/FOO tuli:/tmp:% sudo touch fattest/foo/bar tuli:/tmp:% sudo touch fattest/FOO/Quux tuli:/tmp:% ls -al fattest/FOO/quux -rwxr-xr-x 1 root root 0 Dec 5 01:13 fattest/FOO/quux tuli:/tmp:% ls -al fattest/FOO/Quux -rwxr-xr-x 1 root root 0 Dec 5 01:13 fattest/FOO/Quux tuli:/tmp:% ls -alR fattest/ fattest/: total 8 drwxr-xr-x 3 root root 4096 Dec 5 01:13 . drwxrwxrwt 71 root root 2000 Dec 5 01:12 .. drwxr-xr-x 2 root root 4096 Dec 5 01:13 FOO fattest/FOO: total 8 drwxr-xr-x 2 root root 4096 Dec 5 01:13 . drwxr-xr-x 3 root root 4096 Dec 5 01:13 .. -rwxr-xr-x 1 root root 0 Dec 5 01:13 bar -rwxr-xr-x 1 root root 0 Dec 5 01:13 Quux Teemu, Uncomment this line : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/importui/main/importui.cpp#L2191 And check : 1/ if capitalization problem disappear 2/ if there is no regression with bug #136927 Gilles Caulier Teemu, Do you seen my previous comment ? Gilles Cauleir This file still valid using last digiKam 5.0.0 ? Gilles Caulier This problem still reproducible using last DK 5.4.0 bundle ? https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWlRJenM Gilles Caulier Git commit 36203280f48eb2e04ecc0b95d41597b2f16eacac by Maik Qualmann. Committed on 10/12/2016 at 20:13. Pushed by mqualmann into branch 'master'. remove lower case conversion from sub album creation FIXED-IN: 5.4.0 M +2 -1 NEWS M +0 -8 utilities/importui/main/importui.cpp https://commits.kde.org/digikam/36203280f48eb2e04ecc0b95d41597b2f16eacac |