Bug 327162

Summary:	Trilinear/HiQuality filtering has artifacts in Wraparound mode
Product:	[Applications] krita	Reporter:	Paul Geraskin <paulgeraskin>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/f4b0b17d969e083fb63c1280dae0fdf6742c1999	Version Fixed In:
Sentry Crash Report:

Description Paul Geraskin 2013-11-05 09:37:52 UTC

Hi guys!

Trilinear/HiQuality filtering has artifacts in Wraparound mode.
Here is the screenshot: http://i.imgur.com/MLOosNo.png

The issue happent with less 100% scale size.
50% and 25% have no issues.

DmitryK know about this issue.

Thanks.

Comment 1 Halla Rempt 2013-11-15 10:59:04 UTC

Hi Paul,

Thanks for your report. I can confirm the issue indeed.

Comment 2 Dmitry Kazakov 2013-12-12 18:40:42 UTC

Git commit 5ddc8d91a06b251ace3c5470841ad1efe3b5a7e8 by Dmitry Kazakov.
Committed on 12/12/2013 at 18:40.
Pushed by dkazakov into branch 'master'.

Fix the border effect when working in Trilinear/HiQuality mode

The borders should be as wide as needed, but not just 1px

M  +49   -28   krita/ui/opengl/kis_texture_tile.cpp

http://commits.kde.org/calligra/5ddc8d91a06b251ace3c5470841ad1efe3b5a7e8

Comment 3 Dmitry Kazakov 2013-12-12 18:41:17 UTC

Git commit 948565ced12ef4f3de1022e551a7467b3e3c27f4 by Dmitry Kazakov.
Committed on 12/12/2013 at 18:40.
Pushed by dkazakov into branch 'calligra/2.8'.

Fix the border effect when working in Trilinear/HiQuality mode

The borders should be as wide as needed, but not just 1px

M  +49   -28   krita/ui/opengl/kis_texture_tile.cpp

http://commits.kde.org/calligra/948565ced12ef4f3de1022e551a7467b3e3c27f4

Comment 4 Paul Geraskin 2013-12-13 09:53:55 UTC

Dmitry, hello!

I still have artifacts in wraparound mode. And with your patch i have now even in Bilinear mode.
Screenshot: http://i.imgur.com/Yo4K0Jf.png

Just create 256x256px image and dra like i did.

Comment 5 Paul Geraskin 2013-12-13 09:54:43 UTC

i reopen for a while.

Comment 6 Dmitry Kazakov 2013-12-13 13:59:34 UTC

Git commit 007355c15f29b910983b20de7a1dbb136197ad4b by Dmitry Kazakov.
Committed on 13/12/2013 at 13:59.
Pushed by dkazakov into branch 'master'.

Properly fix the Wrap-Around mode

1) The size of the data stored in the patch does not contain the border
2) The exponent of the border formula should be exactly the number of
   mipmal levels

M  +1    -1    krita/ui/kis_config.cc
M  +3    -7    krita/ui/opengl/kis_texture_tile.cpp

http://commits.kde.org/calligra/007355c15f29b910983b20de7a1dbb136197ad4b

Comment 7 Dmitry Kazakov 2013-12-13 14:01:09 UTC

Git commit f4b0b17d969e083fb63c1280dae0fdf6742c1999 by Dmitry Kazakov.
Committed on 13/12/2013 at 13:59.
Pushed by dkazakov into branch 'calligra/2.8'.

Properly fix the Wrap-Around mode

1) The size of the data stored in the patch does not contain the border
2) The exponent of the border formula should be exactly the number of
   mipmal levels

M  +1    -1    krita/ui/kis_config.cc
M  +3    -7    krita/ui/opengl/kis_texture_tile.cpp

http://commits.kde.org/calligra/f4b0b17d969e083fb63c1280dae0fdf6742c1999

Comment 8 Paul Geraskin 2013-12-14 18:50:55 UTC

Hi Dmitry!

I tested again with your latest changes:
Bilinear - has no artifacts
Trilinear and Hi-Quality have artifacts with 12-10% of zooming http://i.imgur.com/eC7VI9x.png

Comment 9 Paul Geraskin 2013-12-14 18:56:49 UTC

20-10% of zooming *

Comment 10 Paul Geraskin 2013-12-14 19:02:54 UTC

And even 50% of Trilinear filter has artifacts http://i.imgur.com/x73CNTu.png

Comment 11 Paul Geraskin 2013-12-16 11:06:14 UTC

Fixed! Need to remove critaarc.