Bug 326831

Summary:	kde-open fails to open ed2k:// link
Product:	[Unmaintained] kio	Reporter:	envite
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	adawit, sl1pkn07
Priority:	NOR
Version:	4.10.5
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description envite 2013-10-29 14:45:37 UTC

I have the correct .protocol file: ~/.kde/share/kde4/services/ed2k.protocol

[Protocol]
exec=/usr/bin/ed2k "%u"
protocol=ed2k
input=none
output=none
helper=true
listing=false
reading=false
writing=false
makedir=false
deleting=false

I clicked a well-formed ed2k link in Chromium, which called xdg-open, which in turn called kde-open, which failed with the "Wrong URL format" message.

Reproducible: Always

Steps to Reproduce:
1. Create a .protocol file for the ed2k:// schema
2. Click a ed2k:// link or try kde-open on the command line
3. See it fail



This may be related to QUrl::isValid() as explained in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701849

Seems that same happens to ALL schemas that does not start with a host name

Comment 1 Jekyll Wu 2013-10-30 08:08:00 UTC

ed2k links are invalid URLs. See https://bugs.kde.org/show_bug.cgi?id=248682#c2 .

Comment 2 envite 2013-10-30 15:02:09 UTC

On 30/10/13 08:08, Jekyll Wu wrote:
> https://bugs.kde.org/show_bug.cgi?id=326831
>
> --- Comment #1 from Jekyll Wu <adaptee@gmail.com> ---
> ed2k links are invalid URLs. See https://bugs.kde.org/show_bug.cgi?id=248682#c2
> .
>
So, you are saying KDE's URL checking is broken and you will not fix it. 
Instead of delegating the work of processing the URL to the user-defined 
app for the scheme you take the right to forbid it on your own. And the 
injured are the users who can not click on properly-formed ed2k links.

Isn't that?

Noel
er Envite

Comment 3 Jekyll Wu 2013-10-30 15:19:03 UTC

No, read comment #1. Did I say anything you have imagined ?

Comment 4 envite 2013-11-01 13:37:19 UTC

Still, the point stands. Will you continue stealing fro the users the ability to click on ed2k links? That is, will you continue doing the "validity" check, even knowing that it breaks users' workflow, instead of allowing the receiving app do their own checking?

Comment 5 Dawit Alemayehu 2013-11-09 17:59:22 UTC

(In reply to comment #4)
> Still, the point stands. Will you continue stealing fro the users the
> ability to click on ed2k links? That is, will you continue doing the
> "validity" check, even knowing that it breaks users' workflow, instead of
> allowing the receiving app do their own checking?

This is just utter nonsense! "Steal fro the users" ?!?! Which part of ed2k URL is not a valid URL is hard to understand?!?! How can KDE's URL checking be broken when people who developed ed2k utterly ignore long standing standards!??!? In case you did not understand it the first time read RFC 3987 or any of its predecessors, http://www.faqs.org/rfcs/rfc3987.html.

*** This bug has been marked as a duplicate of bug 248682 ***

Comment 6 envite 2013-11-09 21:01:41 UTC

I do not care if they are valid links or not. I just care that out of KDE they work, and in KDE they do not work, so KDE has stolen from the users the ability to click on ed2k links and have them opened.

You should rely on the receiving app doing its own checks instead of interfering.

Comment 7 Christoph Feck 2013-11-17 16:03:50 UTC

xdg-open is a script. You could apply some magic there to make it not run through kde-open, if it is not a valid URL.

Comment 8 Gustavo Alvarez 2014-09-26 23:24:06 UTC

xdg-open call kde-open, kde-open refuse launch any config in xdg-open (like http://unix.stackexchange.com/questions/38650/adding-bindings-for-ed2k-links-with-xdg-open) when ed2k lik is parsed, then.... BANG!. crashed

please add ed2k support in kde-open (like a exception of the rule)

greetings