Bug 326351

Summary:	Wallpaper manager works incorrectly after search
Product:	[Unmaintained] kdelibs	Reporter:	CrustY <crustyftw>
Component:	knewstuff	Assignee:	Jeremy Whiting <jpwhiting>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gladhorn, plasma-bugs
Priority:	NOR
Version:	4.11.0
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/kdelibs/8a20161d1ac9ab84117f9eff2a9e7f032d757ad6	Version Fixed In:	4.11.3
Sentry Crash Report:

Description CrustY 2013-10-20 23:37:01 UTC

To reproduce this issue I just opened wallpapers manager where you can add wallpapers (tap to "Get new wallpapers..." button). There's a list of wallpapers which is loading separately by ~20 wallpaper images, but when user reachs last image manager loading next ~20 etc. But If user use search this mechamism stop to work. No images loading and I can see only previously loaded wallpapers.

Reproducible: Always

Steps to Reproduce:
1. Right click on desktop
2. Tap "Default Desktop settings"
3. Tap "Get New Wallpapers..."
4. Scroll to the end of list (or don't)
5. Use search
6. Clean search field
7. Scroll again
Actual Results:  
No wallpapers loading anymore

Expected Results:  
Load further wallpapers

Comment 1 Jeremy Whiting 2013-10-23 18:20:52 UTC

Git commit 55d1644b025ededda5e06adbaa9118a9e7fd173f by Jeremy Whiting.
Committed on 23/10/2013 at 18:05.
Pushed by whiting into branch 'master'.

Fix bug in knewstuff downloadwidget where using search breaks continuous loading.
FIXED-IN: 4.11.3

M  +5    -0    knewstuff/knewstuff3/core/engine.cpp

http://commits.kde.org/kdelibs/55d1644b025ededda5e06adbaa9118a9e7fd173f

Comment 2 Jeremy Whiting 2013-10-23 18:21:26 UTC

Git commit 4b26a5aabc434fa55d7cac5d9f75fa8890706a5f by Jeremy Whiting.
Committed on 23/10/2013 at 18:05.
Pushed by whiting into branch 'KDE/4.11'.

Fix bug in knewstuff downloadwidget where using search breaks continuous loading.
FIXED-IN: 4.11.3

(cherry picked from commit 55d1644b025ededda5e06adbaa9118a9e7fd173f)

M  +5    -0    knewstuff/knewstuff3/core/engine.cpp

http://commits.kde.org/kdelibs/4b26a5aabc434fa55d7cac5d9f75fa8890706a5f

Comment 3 Jeremy Whiting 2013-10-23 22:48:10 UTC

Git commit 8a20161d1ac9ab84117f9eff2a9e7f032d757ad6 by Jeremy Whiting.
Committed on 23/10/2013 at 22:31.
Pushed by whiting into branch 'frameworks'.

Fix bug in knewstuff downloadwidget where using search breaks continuous loading.
FIXED-IN: 4.11.3

M  +5    -0    knewstuff/src/core/engine.cpp

http://commits.kde.org/kdelibs/8a20161d1ac9ab84117f9eff2a9e7f032d757ad6

Comment 4 CrustY 2013-10-24 06:00:58 UTC

this is awesome, thanks!

Comment 5 Jeremy Whiting 2013-10-24 17:05:35 UTC

No problem, thanks for finding and reporting the bug.