Bug 326175

Summary:	releasechecker should be called WAY less
Product:	[Unmaintained] muon	Reporter:	Harald Sitter <sitter>
Component:	misc	Assignee:	Jonathan Thomas <echidnaman>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	adaptee, aleixpol, plusfabi
Priority:	NOR	Keywords:	triaged
Version First Reported In:	2.0.65
Target Milestone:	---
Platform:	unspecified
OS:	Other
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Reduce calls

Description Harald Sitter 2013-10-17 23:59:34 UTC

right now if one starts any muon GUI it will immediately trigger releasechecker. always.

particularly for -discover -installer that's terrible because there is already a lot of IO going on so you really do not need the checker eating resources as well.

also this causes *pointless* bandwith usage which is incredibly undesirable on limited data plans.

to resolve this issue I suggest that
a) checker is only called when being in an update GUI context meaning unless I open the installed-software-tab in muon (from where I can do updates) or muon-updater.
b) other than that checker is only called by the kded module
c) make checks peristent. this can be for the session (i.e. unless one logs out no version of muonwill attempt another check) or for the datetime (i.e. unless the day changes it is not checked again). or better yet both :P

so ultimately you have an async invocation in the kded module some 5 minutes after login + continous checks on day change

Reproducible: Always

Comment 1 Aleix Pol 2013-10-29 17:55:30 UTC

Created attachment 83209 [details]
Reduce calls

Been looking through the code, it doesn't make sense that this happens so often. I'm attaching a patch that reduces it to 1 call every muon run.

Can somebody try it?

Comment 2 Harald Sitter 2013-10-31 09:32:58 UTC

Down from 3 invocations to 2 it seems.

Comment 3 Aleix Pol 2015-01-14 17:44:51 UTC

Did this ever get in? is this still a problem?

Comment 4 Aleix Pol 2015-01-15 16:01:53 UTC

*** Bug 325419 has been marked as a duplicate of this bug. ***

Comment 5 Aleix Pol 2015-05-14 15:45:24 UTC

Ping?

Comment 6 Andrew Crouthamel 2018-09-25 21:40:45 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 7 Andrew Crouthamel 2018-10-27 02:42:26 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!