Bug 326107

Summary:	RFE: Add ability to remove old access rules from a wallet
Product:	[Applications] kwalletmanager	Reporter:	Carsten Grohmann <carstengrohmann>
Component:	general	Assignee:	Valentin Rusu <valir>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	wbauer1
Priority:	NOR
Version:	1.10
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-runtime/5f2e8db4eb3e0f44425dfdc7e7d5f2c2fc7e4e93	Version Fixed In:	4.12
Sentry Crash Report:
Attachments:	kwallet access control dialog

Description Carsten Grohmann 2013-10-16 16:42:48 UTC

Hi Developers,

please add the ability to remove access rules from a wallet. The current dialog (see attached image) doesn't provide the ability to remove granted access.

Regards,
Carsten

Reproducible: Always

Steps to Reproduce:
.

Comment 1 Carsten Grohmann 2013-10-16 16:43:26 UTC

Created attachment 82884 [details]
kwallet access control dialog

Comment 2 Wolfgang Bauer 2013-10-16 18:24:53 UTC

(In reply to comment #0)
> The current
> dialog (see attached image) doesn't provide the ability to remove granted
> access.
It does. Right-click on an entry and choose "Delete".

Comment 3 Carsten Grohmann 2013-10-17 18:52:24 UTC

(In reply to comment #2)
> (In reply to comment #0)
> > The current
> > dialog (see attached image) doesn't provide the ability to remove granted
> > access.
> It does. Right-click on an entry and choose "Delete".
That's true. Now I've removed the obsolete entries. 

I've created a temporary wallet during my tests some days ago. It's listed in this dialog too.
I want to remove this wallet from that dialog, but I can't - even I've deleted the wallet already.

Could you provide the ability to remove the whole wallet incl. all granted permissions from this dialog?

Thanks,
Carsten

Comment 4 Valentin Rusu 2013-10-23 12:19:05 UTC

Git commit 49ec1cf251d8e42cce1958a38d7f4d691cb25d98 by Valentin Rusu.
Committed on 23/10/2013 at 12:16.
Pushed by vrusu into branch 'master'.

Clean kwalletrc file by removing entries that correspond to deleted wallets
FIXED-IN: 4.12

M  +17   -2    src/konfigurator/konfigurator.cpp

http://commits.kde.org/kwallet/49ec1cf251d8e42cce1958a38d7f4d691cb25d98

Comment 5 Valentin Rusu 2013-10-23 12:20:55 UTC

Git commit 5f2e8db4eb3e0f44425dfdc7e7d5f2c2fc7e4e93 by Valentin Rusu.
Committed on 23/10/2013 at 12:19.
Pushed by vrusu into branch 'master'.

Also delete allow/deny entries from the rc file when deleting wallets

M  +10   -2    kwalletd/kwalletd.cpp

http://commits.kde.org/kde-runtime/5f2e8db4eb3e0f44425dfdc7e7d5f2c2fc7e4e93

Comment 6 Valentin Rusu 2013-10-23 12:21:59 UTC

There's no need to add such menu entries. Instead, I adjusted the code to automatically delete the corresponding entries (allow/deny) from the rc file.