Bug 325111

Summary: undo/redo does not take effect in the image
Product: [Applications] digikam Reporter: Anders Lund <anderslund>
Component: ImageEditor-UndoAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 3.4.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/5cac0a5f7c911392abdaec28ec776510e9284688 Version Fixed In: 3.5.0
Sentry Crash Report:

Description Anders Lund 2013-09-20 04:43:22 UTC 
With digikam 3.4, I can not use undo/redo in the image editor. It appears correct on toolbar and in the menus, as if applied, but the image does not change. 

Reproducible: Always

Steps to Reproduce:
1. open an image
2. make som (very visible, that is easiest) changes 
3. press undo
Actual Results:  
The image is not reset to the prior state, even though it appears so when looking at the toolbar and in the edit menu

Expected Results:  
Image reset to prior state

I'm using KDE 4.11.1 on Chakra linux
Comment 1 Anders Lund 2013-09-22 09:54:59 UTC 
This was due to missing space on /var (and consequently /var/tmp) - missing warning?
Comment 2 caulier.gilles 2013-09-22 18:56:30 UTC 
Git commit 5cac0a5f7c911392abdaec28ec776510e9284688 by Gilles Caulier.
Committed on 22/09/2013 at 18:45.
Pushed by cgilles into branch 'master'.

add free space check when Editor action is performed to undo/redo cache mechanism.
We check if at least 1 Gb is avaialble, which can be enough to play with photography
FIXED-IN: 3.5.0

M  +16   -8    utilities/imageeditor/core/undocache.cpp

http://commits.kde.org/digikam/5cac0a5f7c911392abdaec28ec776510e9284688